Improve editable.getContent() #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we are triggering too many editable.focus events.
This spec fails as long as a saved range adds an invisible non-breaking empty space. As of now this space is not ignored by the extract text and highlight match methods. And removing the space breaks the current merge implementation since the stored cursor position will be remove during a merge without it.
In line with timdown/rangy@601b80c
Allow document fragments to be passed in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass in document fragments. The idea is to make it easier to work with the document fragments that are returned by
cursor.before()andcursor.after(). The split event also passes abeforeandafterdocument fragment.