Fix: handle special deb package names (bsc#1150113)

Package version for RPM does not contain any '-':

```
susemanager=# select count(*) from rhnpackage;
 count
--------
 217621
(1 row)

susemanager=# select * from rhnpackageevr where version like '%-%';
 id | epoch | version | release | evr
----+-------+---------+---------+-----
(0 rows)

```

For Debian packages, some packages are named with a '-' in their
version, e.g.:

```
	gcc-8-base-8-20180414-1ubuntu2.amd64-deb 	gcc-8-base-8.2.0-1ubuntu2~18.04.amd64-deb
	lib32gcc1-8-20180414-1ubuntu2:1.amd64-deb 	lib32gcc1-8.2.0-1ubuntu2~18.04:1.amd64-deb
	libatomic1-8-20180414-1ubuntu2.amd64-deb 	libatomic1-8.2.0-1ubuntu2~18.04.amd64-deb
	libcc1-0-8-20180414-1ubuntu2.amd64-deb 		libcc1-0-8.2.0-1ubuntu2~18.04.amd64-deb
	libgcc1-8-20180414-1ubuntu2:1.amd64-deb 	libgcc1-8.2.0-1ubuntu2~18.04:1.amd64-deb
	libgomp1-8-20180414-1ubuntu2.amd64-deb 		libgomp1-8.2.0-1ubuntu2~18.04.amd64-deb
	libitm1-8-20180414-1ubuntu2.amd64-deb 		libitm1-8.2.0-1ubuntu2~18.04.amd64-deb
	liblsan0-8-20180414-1ubuntu2.amd64-deb 		liblsan0-8.2.0-1ubuntu2~18.04.amd64-deb
	libmpx2-8-20180414-1ubuntu2.amd64-deb 		libmpx2-8.2.0-1ubuntu2~18.04.amd64-deb
	libquadmath0-8-20180414-1ubuntu2.amd64-deb 	libquadmath0-8.2.0-1ubuntu2~18.04.amd64-deb
	libstdc++6-8-20180414-1ubuntu2.amd64-deb 	libstdc++6-8.2.0-1ubuntu2~18.04.amd64-deb
	libtsan0-8-20180414-1ubuntu2.amd64-deb 		libtsan0-8.2.0-1ubuntu2~18.04.amd64-deb
```

The version is correctly parsed:

```
susemanager=# select * from rhnpackageevr where id in (select evr_id from rhnpackage where name_id in (select id from rhnpackagename where name like '%gcc-8-base%'));
  id  | epoch |  version   |     release      |            evr
------+-------+------------+------------------+---------------------------
  316 |       | 8-20180414 | 1ubuntu2         | (,8-20180414,1ubuntu2)
 1835 |       | 8.3.0      | 6ubuntu1~18.04.1 | (,8.3.0,6ubuntu1~18.04.1)
(2 rows)
```

This PR adds a special check in the version: if it contains a '-', then
we are dealing with a pre-release version of a Debian package. We
replace '-' to '~' to signal that we are dealing with a pre-release
version.

Author: mbologna

java/code/src/com/redhat/rhn/common/util/RpmVersionComparator.java

@@ -29,6 +29,8 @@
  */
 public class RpmVersionComparator implements Comparator<String> {
 
+    public static final String DEBIAN_PACKAGE_VERSION_REGEX = "\\d-\\d{8}";
+
     /**
      * {@inheritDoc}
      */
@@ -51,6 +53,13 @@ public int compare(String o1, String o2) {
         int b1 = 0;
         int b2 = 0;
 
+        // Ubuntu/Debian package handling: 8-20180414 is older than 8.3.0 (bsc#1150113)
+        if (str1.matches(DEBIAN_PACKAGE_VERSION_REGEX)) {
+            str1 = str1.replace("-", "~");
+        }
+        if (str2.matches(DEBIAN_PACKAGE_VERSION_REGEX)) {
+            str2 = str2.replace("-", "~");
+        }
 
         /* loop through each version segment of str1 and str2 and compare them */
         while (true) {

java/code/src/com/redhat/rhn/common/util/test/RpmVersionComparatorTest.java

@@ -102,6 +102,12 @@ public void testCaretSorting() {
         assertCompareSymm(1, "1.0^20160102", "1.0^20160101^git1");
     }
 
+    public void testUbuntuBugzilla1150113() {
+        assertCompareSymm(-1, "8-20180414", "8.3.0");
+        assertCompareSymm(-1, "2.7.15~rc1", "2.7.15");
+        assertCompareSymm(-1, "1.20.4", "14.1");
+    }
+
     /* from official rpm tests */
     public void testTildeAndCaretSorting() {
         assertCompareSymm(1, "1.0~rc1^git1", "1.0~rc1");

schema/spacewalk/postgres/packages/rpm.pkb

@@ -60,11 +60,19 @@ $$ language 'plpgsql';
         then
             RAISE EXCEPTION 'VALUE_ERROR.';
         end if;
-      
+
         if str1 = str2
         then
             return 0;
         end if;
+        if regexp_match(str1, '[[:digit:]](-)[[:digit:]]{8}') is not null
+	    then
+		    str1 := replace(str1, '-', '~');
+	    end if;
+        if regexp_match(str2, '[[:digit:]](-)[[:digit:]]{8}') is not null
+	    then
+		    str2 := replace(str2, '-', '~');
+	    end if;
         one := str1;
         two := str2;