run commands with standard environment

Author: mcalmer

susemanager-utils/susemanager-sls/src/modules/supportdata.py

@@ -104,7 +104,7 @@ def get(cmd_args: str = "", **kwargs) -> Dict[str, Any]:
         os.makedirs(output_dir, exist_ok=True)
         cmd.extend(extra_args)
         log.debug("executing: %s", cmd)
-        ret = __salt__["cmd.run_all"](cmd, python_shell=False)
+        ret = __salt__["cmd.run_all"](cmd, runas="root")
 
         log.debug("return: %s", ret)
         returncode = ret["retcode"]

susemanager-utils/susemanager-sls/src/tests/test_module_supportdata.py

@@ -47,7 +47,7 @@ def test_supportdata_suse():
 
         supportdata.__salt__["cmd.run_all"].assert_called_once_with(
             ["/sbin/supportconfig", "-R", "/var/log/supportdata"],
-            python_shell=False,
+            runas="root",
         )
 
 
@@ -76,7 +76,7 @@ def test_supportdata_suse_extra_args():
                 "-l",
                 "10000",
             ],
-            python_shell=False,
+            runas="root",
         )
 
 
@@ -103,7 +103,7 @@ def test_supportdata_mlm_proxy():
                 "--output",
                 "/var/log/supportdata",
             ],
-            python_shell=False,
+            runas="root",
         )
 
 
@@ -130,7 +130,7 @@ def test_supportdata_mlm_server():
                 "--output",
                 "/var/log/supportdata",
             ],
-            python_shell=False,
+            runas="root",
         )
 
 
@@ -156,7 +156,7 @@ def test_supportdata_redhat():
                 "--tmp-dir",
                 "/var/log/supportdata",
             ],
-            python_shell=False,
+            runas="root",
         )
 
 
@@ -183,7 +183,7 @@ def test_supportdata_debian():
                 "--tmp-dir",
                 "/var/log/supportdata",
             ],
-            python_shell=False,
+            runas="root",
         )