Skip to content

Commit c9106f0

Browse files
authored
style: Remove outdated comments about the use of the former _Parameter protocol (#3448)
1 parent 485eae5 commit c9106f0

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

altair/vegalite/v5/api.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,6 @@ def _get_channels_mapping() -> dict[type[SchemaBase], str]:
240240
class Parameter(_expr_core.OperatorMixin):
241241
"""A Parameter object"""
242242

243-
# NOTE: If you change this class, make sure that the protocol in
244-
# altair/vegalite/v5/schema/core.py is updated accordingly if needed.
245-
246243
_counter: int = 0
247244

248245
@classmethod

tools/schemapi/utils.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -336,11 +336,9 @@ def get_python_type_representation(
336336
class_names = ["SchemaBase"]
337337
if self.title == "ExprRef":
338338
# In these cases, a value parameter is also always accepted.
339-
# We use the _Parameter to indicate this although this
340-
# protocol would also pass for selection parameters but
341-
# due to how the Parameter class is defined, it would be quite
342-
# complex to further differentiate between a value and
343-
# a selection parameter based on the type system (one could
339+
# It would be quite complex to further differentiate
340+
# between a value and a selection parameter based on
341+
# the type system (one could
344342
# try to check for the type of the Parameter.param attribute
345343
# but then we would need to write some overload signatures for
346344
# api.param).

0 commit comments

Comments
 (0)