fix: Check if adding to registry in useInsertionEffect fails and fall back to useLayoutEffect #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRH
changed the title
huozhi
reviewed
Apr 29, 2025
…l back to useLayoutEffect if it wont (vercel#856)
JeremyRH
force-pushed
the
fix-useInsertionEffect-no-doc-head
branch
from
537928d to
9c803ea
Compare
|
🎉 This PR is included in version 5.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #856.
This will call both
useInsertionEffectanduseLayoutEffectand a ref is used to return early inuseLayoutEffectifuseInsertionEffectworked.I tried to add tests but it seems like a fairly complete DOM implementation is needed. I didn't feel comfortable adding jsdom or happy-dom.