Skip to content

Bug Report: local_example is only testing etcd topo in matrix build #18355

Open
@morgo

Description

@morgo

Overview of the Issue

The GitHub actions workflow does this:

export TOPO=${{matrix.topo}}
if [ "${{matrix.os}}" = "macos-latest" ]; then
export PATH="/usr/local/opt/[email protected]/bin:$PATH"
fi
eatmydata -- go run test.go -print-log -follow -retry=1 local_example

But the export on TOPO is not propagated to the container. You can see this by looking in any of the recent actions @ https://github.com/vitessio/vitess/actions?query=workflow%3Alocal_example

Expand "local_example" on one for zk/consul, and you'll see:

++ ETCD_SERVER=localhost:2379
++ TOPOLOGY_FLAGS='--topo_implementation etcd2 --topo_global_server_address localhost:2379 --topo_global_root /vitess/global'

Reproduction Steps

Observed in CI, not user-facing.

Binary Version

affects main

Operating System and Environment details

n/a

Log Fragments

++ alias 'vtctl=vtctl --config-file-not-found-handling=ignore'
++ '[' '' = zk2 ']'
++ '[' '' = consul ']'
++ ETCD_SERVER=localhost:2379
++ TOPOLOGY_FLAGS='--topo_implementation etcd2 --topo_global_server_address localhost:2379 --topo_global_root /vitess/global'
++ mkdir -p /vt/vtdataroot/etcd
++ mkdir -p /vt/vtdataroot/tmp

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs TriageThis issue needs to be correctly labelled and triagedType: Bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions