Return error response for unknown transaction hash in debug_traceTransaction

Previously, debug_traceTransaction returned a success response with null
result when the transaction hash was not found. Now it returns a proper
JSON-RPC error response with code -32000 and message Transaction not found,
aligning with the debug RPC endpoints specification.

Refs: besu-eth#10115

Signed-off-by: Vivek Singh Solanki <viveksolanki0509@gmail.com>

Author: vivek-0509

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugTraceTransaction.java

@@ -22,6 +22,7 @@
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.parameters.TransactionTraceParams;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.processor.Tracer;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.processor.TransactionTracer;
+import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcErrorResponse;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcResponse;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcSuccessResponse;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.RpcErrorType;
@@ -91,7 +92,8 @@ public JsonRpcResponse response(final JsonRpcRequestContext requestContext) {
       return new JsonRpcSuccessResponse(
           requestContext.getRequest().getId(), debugResult.getResult());
     } else {
-      return new JsonRpcSuccessResponse(requestContext.getRequest().getId(), null);
+      return new JsonRpcErrorResponse(
+          requestContext.getRequest().getId(), RpcErrorType.TRANSACTION_NOT_FOUND);
     }
   }
 

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugTraceTransactionTest.java

@@ -28,8 +28,10 @@
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.processor.Tracer;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.processor.TransactionTrace;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.processor.TransactionTracer;
+import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcErrorResponse;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcResponse;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcSuccessResponse;
+import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.RpcErrorType;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.results.OpCodeLoggerTracerResult;
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.results.StructLog;
 import org.hyperledger.besu.ethereum.api.query.BlockchainQueries;
@@ -181,48 +183,16 @@ public void shouldTraceTheTransactionUsingTheTransactionTracer() {
 
   @Test
   public void shouldNotTraceTheTransactionIfNotFound() {
-    final Map<String, Boolean> map = new HashMap<>();
-    map.put("disableStorage", true);
-    final Object[] params = new Object[] {transactionHash, map};
+    final Object[] params = new Object[] {transactionHash};
     final JsonRpcRequestContext request =
         new JsonRpcRequestContext(new JsonRpcRequest("2.0", "debug_traceTransaction", params));
-    final TransactionProcessingResult result = mock(TransactionProcessingResult.class);
 
-    final TraceFrame traceFrame =
-        TraceFrame.builder()
-            .setPc(12)
-            .setOpcode("NONE")
-            .setOpcodeNumber(Integer.MAX_VALUE)
-            .setGasRemaining(45L)
-            .setGasCost(OptionalLong.of(56L))
-            .setGasRefund(0L)
-            .setDepth(2)
-            .setRecipient(null)
-            .setValue(Wei.ZERO)
-            .setInputData(Bytes.EMPTY)
-            .setOutputData(Bytes.EMPTY)
-            .setWorldUpdater(null)
-            .setRevertReason(Optional.of(Bytes.fromHexString("0x1122334455667788")))
-            .setStackItemsProduced(0)
-            .setVirtualOperation(false)
-            .build();
-    final List<TraceFrame> traceFrames = Collections.singletonList(traceFrame);
-    final TransactionTrace transactionTrace =
-        new TransactionTrace(transaction, result, traceFrames);
-    when(transaction.getGasLimit()).thenReturn(100L);
-    when(result.getGasRemaining()).thenReturn(27L);
-    when(result.getOutput()).thenReturn(Bytes.fromHexString("1234"));
-    when(blockchainQueries.headBlockNumber()).thenReturn(12L);
     when(blockchainQueries.transactionByHash(transactionHash)).thenReturn(Optional.empty());
-    when(transactionTracer.traceTransaction(
-            any(Tracer.TraceableState.class),
-            eq(blockHash),
-            eq(transactionHash),
-            any(DebugOperationTracer.class)))
-        .thenReturn(Optional.of(transactionTrace));
-    final JsonRpcSuccessResponse response =
-        (JsonRpcSuccessResponse) debugTraceTransaction.response(request);
 
-    assertThat(response.getResult()).isNull();
+    final JsonRpcResponse response = debugTraceTransaction.response(request);
+    assertThat(response).isInstanceOf(JsonRpcErrorResponse.class);
+    final JsonRpcErrorResponse errorResponse = (JsonRpcErrorResponse) response;
+    assertThat(errorResponse.getErrorType())
+        .isEqualByComparingTo(RpcErrorType.TRANSACTION_NOT_FOUND);
   }
 }