Skip to content

Commit 2a9f808

Browse files
warning log if strconv.Atoi failed
Signed-off-by: 蒋筱斌 <[email protected]>
1 parent b25f792 commit 2a9f808

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

pkg/plugins/gateway/algorithms/pd_disaggregation.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -810,12 +810,16 @@ func (r *pdRouter) getPodPromptRange(pod *v1.Pod) (int, int) {
810810
if val, ok := pod.Labels[PromptMinLength]; ok {
811811
if parsed, err := strconv.Atoi(val); err == nil {
812812
minLength = parsed
813+
} else {
814+
klog.Warningf("failed to parse pod label %s with value %s as integer: %v", PromptMinLength, val, err)
813815
}
814816
}
815817

816818
if val, ok := pod.Labels[PromptMaxLength]; ok {
817819
if parsed, err := strconv.Atoi(val); err == nil {
818820
maxLength = parsed
821+
} else {
822+
klog.Warningf("failed to parse pod label %s with value %s as integer: %v", PromptMaxLength, val, err)
819823
}
820824
}
821825

pkg/plugins/gateway/algorithms/pd_disaggregation_test.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1424,22 +1424,25 @@ func TestGetPromptLength(t *testing.T) {
14241424
{
14251425
name: "single message in messages",
14261426
requestBody: `{"messages": [{"role": "user", "content": "Hello World"}]}`,
1427-
expected: len(func() []int { t, _ := utils.TokenizeInputText("Hello World"); return t }()),
1427+
expected: len(func() []int { tokens, _ := utils.TokenizeInputText("Hello World"); return tokens }()),
14281428
},
14291429
{
14301430
name: "multiple messages in messages",
14311431
requestBody: `{"messages": [{"role": "system", "content": "You are a helpful assistant."}, {"role": "user", "content": "Hello World"}]}`,
1432-
expected: len(func() []int { t, _ := utils.TokenizeInputText("You are a helpful assistant.Hello World"); return t }()),
1432+
expected: len(func() []int {
1433+
tokens, _ := utils.TokenizeInputText("You are a helpful assistant.Hello World")
1434+
return tokens
1435+
}()),
14331436
},
14341437
{
14351438
name: "prompt field",
14361439
requestBody: `{"prompt": "Hello World"}`,
1437-
expected: len(func() []int { t, _ := utils.TokenizeInputText("Hello World"); return t }()),
1440+
expected: len(func() []int { tokens, _ := utils.TokenizeInputText("Hello World"); return tokens }()),
14381441
},
14391442
{
14401443
name: "input field",
14411444
requestBody: `{"input": "Hello World"}`,
1442-
expected: len(func() []int { t, _ := utils.TokenizeInputText("Hello World"); return t }()),
1445+
expected: len(func() []int { tokens, _ := utils.TokenizeInputText("Hello World"); return tokens }()),
14431446
},
14441447
{
14451448
name: "invalid JSON",
@@ -1459,7 +1462,7 @@ func TestGetPromptLength(t *testing.T) {
14591462
{
14601463
name: "Chinese text",
14611464
requestBody: `{"prompt": "你好世界"}`,
1462-
expected: len(func() []int { t, _ := utils.TokenizeInputText("你好世界"); return t }()),
1465+
expected: len(func() []int { tokens, _ := utils.TokenizeInputText("你好世界"); return tokens }()),
14631466
},
14641467
}
14651468

0 commit comments

Comments
 (0)