Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Commit 082d62f

Browse files
authored
feat: avoid use empty configmaps (#396)
Avoid use empty configmaps in fluentd Signed-off-by: jcriadomarco <jcriadomarco@vmware.com>
1 parent 483d158 commit 082d62f

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

config-reloader/datasource/kube_informer.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,10 @@ func (d *kubeInformerConnection) GetNamespaces(ctx context.Context) ([]*Namespac
160160
if err != nil {
161161
return nil, err
162162
}
163-
163+
if configdata == "" {
164+
logrus.Infof("Skipping namespace: %v because is empty", ns)
165+
continue
166+
}
164167
fragment, err := fluentd.ParseString(configdata)
165168
if err != nil {
166169
return nil, err

config-reloader/datasource/kubedatasource/configmap.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ func (c *ConfigMapDS) readConfig(configmaps []*core.ConfigMap) string {
143143
logrus.Debugf("Loaded config data from config map: %s/%s", cm.ObjectMeta.Namespace, cm.ObjectMeta.Name)
144144
} else {
145145
logrus.Warnf("cannot find entry %s in configmap %s/%s", entryName, cm.ObjectMeta.Namespace, cm.ObjectMeta.Name)
146+
return ""
146147
}
147148
}
148149
return strings.Join(configdata, "\n")

0 commit comments

Comments
 (0)