Merge pull request #1073 from Indy-rbo/bugfix/fix-object.values-shim

[vrotsc]: Fix shimming for Object.values

Author: VenelinBakalov

docs/versions/latest/Components/Archetypes/typescript/General/Known Issues.md

@@ -6,6 +6,7 @@ A list of known typescript archetype issues.
 
 1. [Array functions are not transpiled to vRO code](#array-functions-are-not-transpiled-to-vro-code)
 2. [VROTSC config](#vrotsc-config)
+3. [`Object.entries` not supported](#objectentries-not-supported)
 
 ### Array functions are not transpiled to vRO code
 
@@ -160,3 +161,7 @@ e.g.
   ignoreDeprecations: "5.0"
 };
 ```
+
+### `Object.entries` not supported
+
+The `Object.entries` function is not supported in vRO's Rhino JavaScript engine and currently does not have a Shim replacement, which results in a runtime error when used.

docs/versions/latest/Release.md

@@ -53,6 +53,20 @@ Add the following new definitions:
 ### *Update type definitions for `FileReader` from `o11n-core` plugin*
 Add `close()` method.
 
+### *Bugfix for Shimming `Object.values`*
+
+#### Previous Behavior
+
+Using `Object.values` would not be replaced by a Shim call and would result in a runtime error when ran inside of vRO's Rhino JavaScript engine.
+
+#### New Behavior
+
+Using `Object.values` now correctly gets replaced by a Shim call (`VROES.Shims.objectValues`), preventing runtime errors when executed inside of vRO's Rhino JavaScript engine.
+
+#### Known Issues
+
+* The `Object.entries` function is not supported in vRO's Rhino JavaScript engine and currently does not have a Shim replacement, which results in a runtime error when used.
+
 ## Upgrade procedure
 
 [//]: # (Explain in details if something needs to be done)

maven/archetypes/ts-vra-ng/src/main/resources/archetype-resources/vro/tsconfig.json

@@ -9,8 +9,9 @@
       "ES2015.Collection",
       "ES2015.Iterable",
       "ES2015.Promise",
+      "ES2016.Array.Include",
       "ES2017.String",
-      "ES2016.Array.Include"
+      "ES2017.Object"
     ],
     "experimentalDecorators": true
   }

maven/archetypes/ts/src/main/resources/archetype-resources/tsconfig.json

@@ -9,8 +9,9 @@
       "ES2015.Collection",
       "ES2015.Iterable",
       "ES2015.Promise",
+      "ES2016.Array.Include",
       "ES2017.String",
-      "ES2016.Array.Include"
+      "ES2017.Object"
     ],
     "experimentalDecorators": true
   }

packages/ecmascript/tsconfig.json

@@ -9,8 +9,9 @@
 			"ES2015.Collection",
 			"ES2015.Iterable",
 			"ES2015.Promise",
+			"ES2016.Array.Include",
 			"ES2017.String",
-			"ES2016.Array.Include"
+			"ES2017.Object"
 		],
 		"experimentalDecorators": true
 	}

typescript/vrotsc/e2e/cases/es6-shims/action1.ts

@@ -38,3 +38,5 @@ var obj = {
 obj.startsWith("test");
 obj.find("test");
 obj.findIndex("test");
+Object.assign({}, obj);
+Object.values(obj);

typescript/vrotsc/e2e/expect/es6-shims/actions/action1.js

@@ -43,5 +43,7 @@
     obj.startsWith("test");
     obj.find("test");
     obj.findIndex("test");
+    VROES.Shims.objectAssign({}, obj);
+    VROES.Shims.objectValues(obj);
     return exports;
 });

typescript/vrotsc/e2e/expect/es6-shims/maps/action1.js.map

@@ -41,8 +41,9 @@ export function createCompilerOptions(rootDir: string, projectPath?: string): ts
 				"lib.es2015.collection.d.ts",
 				"lib.es2015.iterable.d.ts",
 				"lib.es2015.promise.d.ts",
+				"lib.es2016.array.include.d.ts",
 				"lib.es2017.string.d.ts",
-				"lib.es2016.array.include.d.ts"
+				"lib.es2017.object.d.ts"
 			],
 			strict: false,
 			allowUnreachableCode: true,

typescript/vrotsc/src/compiler/config.ts

@@ -173,6 +173,8 @@ export function transformShims(sourceFile: ts.SourceFile, context: ScriptTransfo
 					return shimStaticCall("arrayOf", node);
 				case "ObjectConstructor.assign":
 					return shimStaticCall("objectAssign", node);
+				case "ObjectConstructor.values":
+					return shimStaticCall("objectValues", node);
 			}
 		}