fix: data race in configureDevices with PropertyCollector

Use cloneDevice() to create a deep copy of the device list before
modification, preventing race between AssignController writes and
PropertyCollector's deepCopy reads..

Signed-off-by: Zexing Jiang <zexing.jiang@broadcom.com>

Author: Zexing Jiang

simulator/virtual_machine.go

@@ -2086,7 +2086,8 @@ func (vm *VirtualMachine) updateCrypto(
 func (vm *VirtualMachine) configureDevices(ctx *Context, spec *types.VirtualMachineConfigSpec) types.BaseMethodFault {
 	var changes []types.PropertyChange
 	field := mo.Field{Path: "config.hardware.device"}
-	devices := object.VirtualDeviceList(vm.Config.Hardware.Device)
+	// copy devices to prevent data race with PropertyCollector's deepCopy
+	devices := object.VirtualDeviceList(vm.cloneDevice())
 
 	var err types.BaseMethodFault
 	for i, change := range spec.DeviceChange {