Allow data source lookup by id for several data sources (#1965)

The following data sources had the logic to lookup by id, but the schema
validation blocks it:

nsxt_policy_gateway_connection
nsxt_policy_gateway_prefix_list
nsxt_policy_gateway_route_map
nsxt_policy_l2_vpn_service
nsxt_policy_uplink_host_switch_profile
nsxt_policy_vtep_ha_host_switch_profile

The provider should allow to look up this object by id-only

Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>

Author: ksamoray

nsxt/data_source_nsxt_compute_collection.go

@@ -18,7 +18,7 @@ func dataSourceNsxtComputeCollection() *schema.Resource {
 
 		Schema: map[string]*schema.Schema{
 			"id":           getDataSourceIDSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"origin_type": {
 				Type:        schema.TypeString,
 				Optional:    true,

nsxt/data_source_nsxt_policy_gateway_connection.go

@@ -16,7 +16,7 @@ func dataSourceNsxtPolicyGatewayConnection() *schema.Resource {
 			"id":           getDataSourceIDSchema(),
 			"tier0_path":   getPolicyPathSchema(false, false, "Tier0 Gateway path"),
 			"path":         getPathSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"description":  getDescriptionSchema(),
 		},
 	}

nsxt/data_source_nsxt_policy_gateway_prefix_list.go

@@ -18,7 +18,7 @@ func dataSourceNsxtPolicyGatewayPrefixList() *schema.Resource {
 			"id":           getDataSourceIDSchema(),
 			"gateway_path": getPolicyPathSchema(false, false, "Gateway path"),
 			"path":         getPathSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"description":  getDescriptionSchema(),
 		},
 	}

nsxt/data_source_nsxt_policy_gateway_route_map.go

@@ -18,7 +18,7 @@ func dataSourceNsxtPolicyGatewayRouteMap() *schema.Resource {
 			"id":           getDataSourceIDSchema(),
 			"gateway_path": getPolicyPathSchema(false, false, "Gateway path"),
 			"path":         getPathSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"description":  getDescriptionSchema(),
 		},
 	}

nsxt/data_source_nsxt_policy_l2_vpn_service.go

@@ -18,7 +18,7 @@ func dataSourceNsxtPolicyL2VpnService() *schema.Resource {
 			"id":           getDataSourceIDSchema(),
 			"gateway_path": getPolicyPathSchema(false, false, "Gateway path"),
 			"path":         getPathSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"description":  getDescriptionSchema(),
 		},
 	}

nsxt/data_source_nsxt_policy_uplink_host_switch_profile.go

@@ -21,7 +21,7 @@ func dataSourceNsxtUplinkHostSwitchProfile() *schema.Resource {
 		Schema: map[string]*schema.Schema{
 			"id":           getDataSourceIDSchema(),
 			"path":         getPathSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"description":  getDescriptionSchema(),
 			"realized_id": {
 				Type:        schema.TypeString,

nsxt/data_source_nsxt_policy_vtep_ha_host_switch_profile.go

@@ -18,7 +18,7 @@ func dataSourceNsxtVtepHAHostSwitchProfile() *schema.Resource {
 		Schema: map[string]*schema.Schema{
 			"id":           getDataSourceIDSchema(),
 			"path":         getPathSchema(),
-			"display_name": getDisplayNameSchema(),
+			"display_name": getDataSourceDisplayNameSchema(),
 			"description":  getDescriptionSchema(),
 		},
 	}