Go formatting and Lint

Author: sreenivasmrpivot

internal/resources/ekscluster/data_source.go

@@ -10,8 +10,6 @@ import (
 	"log"
 	"strconv"
 	"time"
-	// "os"
-	// "strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -84,19 +82,18 @@ func dataSourceTMCEKSClusterRead(ctx context.Context, d *schema.ResourceData, m
 			return true, nil
 		}
 
-		// if val := os.Getenv("WAIT_FOR_HEALTHY"); strings.EqualFold(val, "TRUE") || val == "" {
 		if isWaitForKubeconfig(d) {
-			clusFullName := &clustermodel.VmwareTanzuManageV1alpha1ClusterFullName { Name: resp.EksCluster.Spec.AgentName, OrgID: clusterFn.OrgID, ManagementClusterName: "eks", ProvisionerName: "eks" }
+			clusFullName := &clustermodel.VmwareTanzuManageV1alpha1ClusterFullName{Name: resp.EksCluster.Spec.AgentName, OrgID: clusterFn.OrgID, ManagementClusterName: "eks", ProvisionerName: "eks"}
 			clusterResp, err := config.TMCConnection.ClusterResourceService.ManageV1alpha1ClusterResourceServiceGet(clusFullName)
 			if err != nil {
 				log.Printf("Unable to get Tanzu Mission Control cluster entry, name : %s", clusterFn.Name)
 			}
-	
+
 			if !isManagemetClusterHealthy(clusterResp) {
 				log.Printf("[DEBUG] waiting for cluster(%s) to be in Healthy status", clusterFn.Name)
 				return true, nil
 			}
-			
+
 			fn := &configModels.VmwareTanzuManageV1alpha1ClusterFullName{
 				ManagementClusterName: "eks",
 				ProvisionerName:       "eks",
@@ -112,7 +109,7 @@ func dataSourceTMCEKSClusterRead(ctx context.Context, d *schema.ResourceData, m
 				}
 			}
 		}
-		
+
 		return false, nil
 	}
 
@@ -159,7 +156,7 @@ func dataSourceTMCEKSClusterRead(ctx context.Context, d *schema.ResourceData, m
 }
 
 func isManagemetClusterHealthy(cluster *clustermodel.VmwareTanzuManageV1alpha1ClusterGetClusterResponse) bool {
-	return cluster.Cluster.Status.Health != nil && *cluster.Cluster.Status.Health == clustermodel.VmwareTanzuManageV1alpha1CommonClusterHealthHEALTHY 
+	return cluster.Cluster.Status.Health != nil && *cluster.Cluster.Status.Health == clustermodel.VmwareTanzuManageV1alpha1CommonClusterHealthHEALTHY
 }
 
 func kubeConfigReady(err error, resp *configModels.VmwareTanzuManageV1alpha1ClusterKubeconfigGetKubeconfigResponse) bool {

internal/resources/ekscluster/data_source_test.go

@@ -10,8 +10,8 @@ import (
 
 	"github.com/stretchr/testify/require"
 
-	eksmodel "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/ekscluster"
 	clustermodel "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/cluster"
+	eksmodel "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/ekscluster"
 )
 
 func TestNodepoolPosMap(t *testing.T) {
@@ -63,10 +63,10 @@ func TestNodepoolPosMap(t *testing.T) {
 
 func TestIsManagemetClusterHealthy(t *testing.T) {
 	tests := []struct {
-		name    string
-		cluster *clustermodel.VmwareTanzuManageV1alpha1ClusterGetClusterResponse
+		name     string
+		cluster  *clustermodel.VmwareTanzuManageV1alpha1ClusterGetClusterResponse
 		response bool
-		err     error
+		err      error
 	}{
 		{
 			name: "Not healthy",
@@ -78,7 +78,7 @@ func TestIsManagemetClusterHealthy(t *testing.T) {
 				},
 			},
 			response: false,
-			err: nil,
+			err:      nil,
 		},
 		{
 			name: "Healthy",
@@ -88,9 +88,9 @@ func TestIsManagemetClusterHealthy(t *testing.T) {
 						Health: clustermodel.NewVmwareTanzuManageV1alpha1CommonClusterHealth(clustermodel.VmwareTanzuManageV1alpha1CommonClusterHealthHEALTHY),
 					},
 				},
-			},		
-			response: true,	
-			err: nil,
+			},
+			response: true,
+			err:      nil,
 		},
 	}
 
@@ -101,4 +101,4 @@ func TestIsManagemetClusterHealthy(t *testing.T) {
 			}
 		})
 	}
-}
+}

internal/resources/ekscluster/resource_ekscluster.go

@@ -96,7 +96,7 @@ var clusterSchema = map[string]*schema.Schema{
 		Type:        schema.TypeString,
 		Description: "Kubeconfig for connecting to newly created cluster base64 encoded. This will only be returned if you have elected to wait for kubeconfig.",
 		Computed:    true,
-	},	
+	},
 }
 
 var clusterSpecSchema = &schema.Schema{
@@ -977,4 +977,4 @@ func isWaitForKubeconfig(data *schema.ResourceData) bool {
 	}
 
 	return false
-}
+}