Fix NOT_AUTHENTICATED errors in Content Library tests (#53)

Signed-off-by: abarreiro <abarreiro@vmware.com>

Author: adambarreiro

.changes/v1.0.0/12-features.md

@@ -1,4 +1,4 @@
-- **New Resource:** `vcfa_content_library` to manage Content Libraries [GH-12, GH-42, GH-43, GH-50]
-- **New Data Source:** `vcfa_content_library` to read Content Libraries [GH-12, GH-42, GH-50]
+- **New Resource:** `vcfa_content_library` to manage Content Libraries [GH-12, GH-42, GH-43, GH-50, GH-53]
+- **New Data Source:** `vcfa_content_library` to read Content Libraries [GH-12, GH-42, GH-50, GH-53]
 - **New Data Source:** `vcfa_region_storage_policy` to read Region Storage Policies [GH-12]
 - **New Data Source:** `vcfa_storage_class` to read Storage Classes [GH-12]

.changes/v1.0.0/13-features.md

@@ -1,2 +1,2 @@
-* **New Resource:** `vcfa_content_library_item` to manage Content Library Items [GH-13, GH-46, GH-50]
+* **New Resource:** `vcfa_content_library_item` to manage Content Library Items [GH-13, GH-46, GH-50, GH-53]
 * **New Data Source:** `vcfa_content_library_item` to read Content Library Items [GH-13]

vcfa/config.go

@@ -72,6 +72,14 @@ type cacheStorage struct {
 	sync.Mutex
 }
 
+// reset clears cache to force re-authentication
+func (c *cacheStorage) reset() {
+	c.Lock()
+	defer c.Unlock()
+	c.cacheClientServedCount = 0
+	c.conMap = make(map[string]cachedConnection)
+}
+
 var (
 	// Enables the caching of authenticated connections
 	enableConnectionCache = os.Getenv("VCFA_CACHE") != ""

vcfa/resource_vcfa_content_library_item_test.go

@@ -261,6 +261,11 @@ func TestAccVcfaContentLibraryItemTenant(t *testing.T) {
 		}
 	}
 
+	// Before this test ends we need to clean up the clients cache, because we create an Org user
+	// and use it to login with the provider. Using same credentials and org name could lead to errors if this user
+	// remains cached.
+	defer cachedVCDClients.reset()
+
 	resource.Test(t, resource.TestCase{
 		Steps: []resource.TestStep{
 			{

vcfa/resource_vcfa_content_library_test.go

@@ -282,6 +282,11 @@ func TestAccVcfaContentLibraryTenant(t *testing.T) {
 		}
 	}
 
+	// Before this test ends we need to clean up the clients cache, because we create an Org user
+	// and use it to login with the provider. Using same credentials and org name could lead to errors if this user
+	// remains cached.
+	defer cachedVCDClients.reset()
+
 	resource.Test(t, resource.TestCase{
 		Steps: []resource.TestStep{
 			{
@@ -423,7 +428,7 @@ resource "vcfa_org" "test" {
 resource "vcfa_org_settings" "allow" {
   org_id                           = vcfa_org.test.id
   can_create_subscribed_libraries  = true
-  quarantine_content_library_items = true
+  quarantine_content_library_items = false
 }
 
 data "vcfa_role" "org-admin" {