Skip to content

Commit a017243

Browse files
authored
control-service: use git for images (#2097)
# Why The most common reason for integration test failures is them being unable to pull the image from docker hub because of throttling limits. In this PR I pull them from github instead which doesn't have the same restrictions. **The newest versions of images aren't automatically published to github and so we need to complete the following ticket asap to ensure the test coverage is always testing the latest version of the product.** #2102 # What Manually uploaded images to github. Updated integration test properties. # How was this tested Locally and CICD --------- Signed-off-by: murphp15 <murphp15@tcd.ie>
1 parent f354de0 commit a017243

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

projects/control-service/projects/pipelines_control_service/src/integration-test/resources/application-test.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ integrationTest.controlNamespace=${CONTROL_K8S_NAMESPACE:}
5757
# property should have the name of the secret in the env.
5858
datajobs.builder.registrySecret=${DATAJOBS_BUILDER_REGISTRY_SECRET:}
5959

60-
datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3
60+
datajobs.builder.image=ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3
6161
datajobs.proxy.repositoryUrl=${DOCKER_REGISTRY_URL}
6262
datajobs.deployment.dataJobBaseImage=versatiledatakit/data-job-base-python-3.7:latest
6363

@@ -76,5 +76,5 @@ alertDefList:%5B%5D%C2%A7partitions:%C2%A7%C2%A7text:CONTAINS:{{execution_id}}*
7676
datajobs.executions.logsUrl.dateFormat=unix
7777

7878
# Python versions supported for the purposes of the deployment integration tests
79-
datajobs.deployment.supportedPythonVersions={3.9: {vdkImage: 'registry.hub.docker.com/versatiledatakit/quickstart-vdk:release', baseImage: 'versatiledatakit/data-job-base-python-3.9:latest'}, 3.8: {vdkImage: 'registry.hub.docker.com/versatiledatakit/quickstart-vdk:pre-release', baseImage: 'versatiledatakit/data-job-base-python-3.8:latest'}}
79+
datajobs.deployment.supportedPythonVersions={3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest'}, 3.8: {vdkImage: 'registry.hub.docker.com/versatiledatakit/quickstart-vdk:pre-release', baseImage: 'versatiledatakit/data-job-base-python-3.8:latest'}}
8080
datajobs.deployment.defaultPythonVersion=3.9

0 commit comments

Comments
 (0)