From 0d1a3696f332a1b1da451e5bcee006e80b4718ec Mon Sep 17 00:00:00 2001 From: paulm2 Date: Thu, 2 Nov 2023 10:24:36 +0000 Subject: [PATCH 01/19] vdk-jupyterlab-extensions: update dependencies --- .../vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml index f14b273a32..f70176f93e 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml @@ -26,8 +26,8 @@ dependencies = [ "jupyter_server>=1.6,<3", "jupyterlab==3.6.3", "traitlets==5.9.0", - "vdk-control-cli", - "vdk-core" + "vdk-control-cli>=1.0.11", + "vdk-core>=0.3.1057638781" ] dynamic = ["version", "description", "authors", "urls", "keywords"] From 380774e7cdbc750247afcdd5591ba137411236bd Mon Sep 17 00:00:00 2001 From: paulm2 Date: Thu, 2 Nov 2023 10:29:13 +0000 Subject: [PATCH 02/19] vdk-jupyterlab-extensions: update dependencies --- .../vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml index f70176f93e..6dd28a1204 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/pyproject.toml @@ -26,7 +26,7 @@ dependencies = [ "jupyter_server>=1.6,<3", "jupyterlab==3.6.3", "traitlets==5.9.0", - "vdk-control-cli>=1.0.11", + "vdk-control-cli>=1.3.1020121059", "vdk-core>=0.3.1057638781" ] dynamic = ["version", "description", "authors", "urls", "keywords"] From 86e34ac5a2912e2c90e234ac493c8b67403db456 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Thu, 2 Nov 2023 15:55:36 +0000 Subject: [PATCH 03/19] vdk-jupyterlab-extensions: run tests in cicd --- .../vdk-plugins/vdk-jupyter/.plugin-ci.yml | 21 +++++++++++++++++++ .../ui-tests/playwright.config.js | 2 +- .../ui-tests/tests/convert-job.spec.ts | 4 +--- .../ui-tests/tests/utils.ts | 1 - .../tests/vdk-jupyterlab-extension.spec.ts | 4 ++-- 5 files changed, 25 insertions(+), 7 deletions(-) diff --git a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml index af35e9fcad..9880a7a6db 100644 --- a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml +++ b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml @@ -35,6 +35,27 @@ build-vdk-jupyterlab-extension: - echo "Building VDK JupyterLab Extension..." - npm rebuild +integration-tests-vdk-jupyterlab-extension: + image: "mcr.microsoft.com/playwright:v1.39.0-jammy" + # extends: .common-setup-vdk-jupyterlab-extension + stage: pre_release_test + script: + - apt install software-properties-common -y + - add-apt-repository ppa:deadsnakes/ppa + - apt install python3.9 python3.9-venv -y + - python3.9 -m venv venv + - source venv/bin/activate + - pip install -U pip + - apt-get install -y gcc python3.9-dev + - pip install -e . + - npm rebuild + - jlpm install + - jlpm build:prod + - cd ./ui-tests + - jlpm install + - jlpm playwright install + - vim playwright.config.js + - jlpm playwright test server-tests-vdk-jupyterlab-extension: extends: .common-setup-vdk-jupyterlab-extension diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/playwright.config.js b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/playwright.config.js index 4e5c44b74e..b7e20a5d1b 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/playwright.config.js +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/playwright.config.js @@ -11,7 +11,7 @@ const baseConfig = require('@jupyterlab/galata/lib/playwright-config'); module.exports = { ...baseConfig, webServer: { - command: 'jlpm start', + command: 'jlpm start --allow-root', url: 'http://localhost:8888/lab', timeout: 200 * 100000, reuseExistingServer: !process.env.CI diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts index 7ee430ecde..93026a468a 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts @@ -9,7 +9,6 @@ import path from 'path'; import { copyDirectory } from './utils'; const baseJobPath = 'data/convert-test-job-dirty'; test.use({ autoGoto: false }); - test.describe('convert job', () => { test.beforeEach(async ({ baseURL, page, tmpPath }) => { await copyDirectory( @@ -20,8 +19,7 @@ test.describe('convert job', () => { await page.goto(`tree/${tmpPath}`); }); - - test('success', async ({ page }) => { + test.skip('success', async ({ page }) => { // use VDK menu await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Convert').click(); diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/utils.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/utils.ts index fdb2343148..a06fb9825f 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/utils.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/utils.ts @@ -4,7 +4,6 @@ */ import { galata } from '@jupyterlab/galata'; -import path from 'path'; export async function copyDirectory( baseURL: string, diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index 3d897786c7..fe8d11f971 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -93,7 +93,7 @@ test('should try to create a job with incorrect input and get error', async ({ await page.getByRole('button', { name: 'OK' }).click(); }); -test('should try to create a job successfully', async ({ page }) => { +test.skip('should try to create a job successfully', async ({ page }) => { await page.goto(''); await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Create').click(); @@ -146,7 +146,7 @@ test('should create an init cell when opening a new notebook', async ({ ).toBeVisible(); }); -test( +test.skip( 'should create a new dir, navigate to it,' + 'create a new job, attempt to create a job relative to' + 'the original dir and succeed', From 7825c0b7d9758d4fb81db9b0fbaf8be22b75c676 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Thu, 2 Nov 2023 19:19:28 +0000 Subject: [PATCH 04/19] vdk-jupyterlab-extensions: run tests in cicd --- projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml index 9880a7a6db..57c0eb20c6 100644 --- a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml +++ b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml @@ -40,6 +40,7 @@ integration-tests-vdk-jupyterlab-extension: # extends: .common-setup-vdk-jupyterlab-extension stage: pre_release_test script: + - apt update - apt install software-properties-common -y - add-apt-repository ppa:deadsnakes/ppa - apt install python3.9 python3.9-venv -y From fccc6bcb736cb8f328286fc5c1f7a839a9f31b20 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 08:30:58 +0000 Subject: [PATCH 05/19] vdk-jupyterlab-extensions: run tests in cicd --- projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml index 57c0eb20c6..05024ac508 100644 --- a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml +++ b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml @@ -43,7 +43,7 @@ integration-tests-vdk-jupyterlab-extension: - apt update - apt install software-properties-common -y - add-apt-repository ppa:deadsnakes/ppa - - apt install python3.9 python3.9-venv -y + - DEBIAN_FRONTEND=noninteractive apt install python3.9 python3.9-venv -y - python3.9 -m venv venv - source venv/bin/activate - pip install -U pip From bcb23a11e72bfb98ca6c8a6de4bab5c5edb0c771 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 08:55:11 +0000 Subject: [PATCH 06/19] vdk-jupyterlab-extensions: run tests in cicd --- projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml index 05024ac508..f15c5282ac 100644 --- a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml +++ b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml @@ -40,6 +40,7 @@ integration-tests-vdk-jupyterlab-extension: # extends: .common-setup-vdk-jupyterlab-extension stage: pre_release_test script: + - cd projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension - apt update - apt install software-properties-common -y - add-apt-repository ppa:deadsnakes/ppa From 8db171fbceb5bdd4cb324b3525b649daa4a5b943 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 09:12:06 +0000 Subject: [PATCH 07/19] vdk-jupyterlab-extensions: run tests in cicd --- projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml index f15c5282ac..f1a81b1faa 100644 --- a/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml +++ b/projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml @@ -56,7 +56,6 @@ integration-tests-vdk-jupyterlab-extension: - cd ./ui-tests - jlpm install - jlpm playwright install - - vim playwright.config.js - jlpm playwright test server-tests-vdk-jupyterlab-extension: From 7618a276ffdde191b483ef94971be1a2b43f442a Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 10:08:07 +0000 Subject: [PATCH 08/19] vdk-jupyterlab-extensions: fix failing test --- .../ui-tests/tests/vdk-jupyterlab-extension.spec.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index fe8d11f971..89b0db42a4 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -93,7 +93,7 @@ test('should try to create a job with incorrect input and get error', async ({ await page.getByRole('button', { name: 'OK' }).click(); }); -test.skip('should try to create a job successfully', async ({ page }) => { +test('should try to create a job successfully', async ({ page }) => { await page.goto(''); await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Create').click(); @@ -146,10 +146,8 @@ test('should create an init cell when opening a new notebook', async ({ ).toBeVisible(); }); -test.skip( - 'should create a new dir, navigate to it,' + - 'create a new job, attempt to create a job relative to' + - 'the original dir and succeed', +test( + 'should create a new dir, navigate to it,create a new job, attempt to create a job relative tothe original dir and succeed', async ({ page }) => { await page.goto(''); await page.getByRole('button', { name: 'New Folder' }).click(); @@ -158,7 +156,6 @@ test.skip( await page.getByText('test-dir').click(); await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Create').click(); - await page.getByLabel('Local').check(); await page.getByLabel('Job name:').click(); await page.getByLabel('Job name:').fill('first-job'); await page.getByLabel('Job team:').click(); From aa028268eb378c929383f6cd6a8c469755dc83c1 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 10:19:57 +0000 Subject: [PATCH 09/19] vdk-jupyterlab-extensions: fix failing test --- .../ui-tests/tests/convert-job.spec.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts index 93026a468a..8ee287459f 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts @@ -19,7 +19,7 @@ test.describe('convert job', () => { await page.goto(`tree/${tmpPath}`); }); - test.skip('success', async ({ page }) => { + test('success', async ({ page }) => { // use VDK menu await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Convert').click(); @@ -38,6 +38,10 @@ test.describe('convert job', () => { .locator('div') .filter({ hasText: 'Are you sure you want to convert the Data Job' }); await page.getByRole('button', { name: 'OK' }).click(); + + // Dismiss the dialog that says the operation is running in the background + await page.getByRole('button', { name: 'OK' }).click(); + await page.locator('div').filter({ hasText: 'Directory not found' }); await page.getByRole('button', { name: 'Dismiss' }).click(); From 796e4989d5155bc60647b25ed9e1587e2c84b855 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 3 Nov 2023 10:32:30 +0000 Subject: [PATCH 10/19] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- .../tests/vdk-jupyterlab-extension.spec.ts | 37 +++++++++---------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index 89b0db42a4..dda0889a92 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -146,22 +146,21 @@ test('should create an init cell when opening a new notebook', async ({ ).toBeVisible(); }); -test( - 'should create a new dir, navigate to it,create a new job, attempt to create a job relative tothe original dir and succeed', - async ({ page }) => { - await page.goto(''); - await page.getByRole('button', { name: 'New Folder' }).click(); - await page.getByRole('listitem').getByRole('textbox').fill('test-dir'); - await page.getByRole('listitem').getByRole('textbox').press('Enter'); - await page.getByText('test-dir').click(); - await page.menu.open('VDK'); - await page.locator('#jp-vdk-menu').getByText('Create').click(); - await page.getByLabel('Job name:').click(); - await page.getByLabel('Job name:').fill('first-job'); - await page.getByLabel('Job team:').click(); - await page.getByLabel('Job team:').fill('example-team'); - await page.getByLabel('Path to job directory:').click(); - await page.getByLabel('Path to job directory:').fill('test-dir'); - await page.getByRole('button', { name: 'OK' }).click(); - } -); +test('should create a new dir, navigate to it,create a new job, attempt to create a job relative tothe original dir and succeed', async ({ + page +}) => { + await page.goto(''); + await page.getByRole('button', { name: 'New Folder' }).click(); + await page.getByRole('listitem').getByRole('textbox').fill('test-dir'); + await page.getByRole('listitem').getByRole('textbox').press('Enter'); + await page.getByText('test-dir').click(); + await page.menu.open('VDK'); + await page.locator('#jp-vdk-menu').getByText('Create').click(); + await page.getByLabel('Job name:').click(); + await page.getByLabel('Job name:').fill('first-job'); + await page.getByLabel('Job team:').click(); + await page.getByLabel('Job team:').fill('example-team'); + await page.getByLabel('Path to job directory:').click(); + await page.getByLabel('Path to job directory:').fill('test-dir'); + await page.getByRole('button', { name: 'OK' }).click(); +}); From 35804901064afcbf60f16096e8ab4c9b38595715 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 3 Nov 2023 11:33:01 +0000 Subject: [PATCH 11/19] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- .../ui-tests/tests/vdk-jupyterlab-extension.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index 73c6296615..874a4bee6a 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -146,7 +146,6 @@ test('should create an init cell when opening a new notebook', async ({ ).toBeVisible(); }); - test( 'should create a new dir, navigate to it,' + 'create a new job, attempt to create a job relative to' + From bc55699895dc1b1daee6236ee74d6f6acc856989 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 11:52:20 +0000 Subject: [PATCH 12/19] vdk-jupyterlab-extensions: fix failing test --- .../ui-tests/tests/vdk-jupyterlab-extension.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index 874a4bee6a..0fab5f353e 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -158,7 +158,6 @@ test( await page.getByText('test-dir').click(); await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Create').click(); - await page.getByLabel('Local').check(); await page.getByLabel('Job name:').click(); await page.getByLabel('Job name:').fill('first-job'); await page.getByLabel('Job team:').click(); From 17d2df7ffd109b5a4e0cfb959055f70683bdeed7 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 11:53:37 +0000 Subject: [PATCH 13/19] vdk-jupyterlab-extensions: fix failing test --- .../ui-tests/tests/vdk-jupyterlab-extension.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index 0fab5f353e..ac23082c86 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -93,7 +93,7 @@ test('should try to create a job with incorrect input and get error', async ({ await page.getByRole('button', { name: 'OK' }).click(); }); -test.skip('should try to create a job successfully', async ({ page }) => { +test('should try to create a job successfully', async ({ page }) => { await page.goto(''); await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Create').click(); From a26c607d283795184d604ee7bc59a69bec2bb332 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Fri, 3 Nov 2023 15:27:52 +0000 Subject: [PATCH 14/19] vdk-jupyter: include test report --- .../ui-tests/tests/convert-job.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts index d03947d303..d872359681 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts @@ -20,7 +20,7 @@ test.describe('convert job', () => { await page.goto(`tree/${tmpPath}`); }); - test('success', async ({ page }) => { + test.skip('success', async ({ page }) => { // use VDK menu await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Convert').click(); @@ -44,7 +44,7 @@ test.describe('convert job', () => { await page.getByRole('button', { name: 'OK' }).click(); await page.locator('div').filter({ hasText: 'Directory not found' }); - await page.getByRole('button', { name: 'Dismiss' }).click(); + await page.getByRole('button', { name: 'Dismss' }).click(); // get message that the job was converted successfully await page From dba94b3ba172908c3b2d5c6381fd6824c70fe4e0 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Mon, 13 Nov 2023 11:29:36 +0000 Subject: [PATCH 15/19] jupyter: fix it test --- .../ui-tests/tests/vdk-jupyterlab-extension.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts index ac23082c86..880beeaadc 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/vdk-jupyterlab-extension.spec.ts @@ -105,7 +105,7 @@ test('should try to create a job successfully', async ({ page }) => { page.on('dialog', async dialog => { expect(dialog.type()).toContain('alert'); expect(dialog.message()).toContain( - 'Job with name first-job was created successfully!' + 'Job with name first-job was created only locally' ); await dialog.accept(); }); From e12c1b756b40dbbc9c170ec5b1659e929246566f Mon Sep 17 00:00:00 2001 From: paulm2 Date: Mon, 13 Nov 2023 12:45:55 +0000 Subject: [PATCH 16/19] jupyter: fix it test --- .../vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts index d872359681..224a7b57ee 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts @@ -20,7 +20,7 @@ test.describe('convert job', () => { await page.goto(`tree/${tmpPath}`); }); - test.skip('success', async ({ page }) => { + test('success', async ({ page }) => { // use VDK menu await page.menu.open('VDK'); await page.locator('#jp-vdk-menu').getByText('Convert').click(); From 4261b1d395547b193bc6fb5c3acf6e940b8f4a91 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Mon, 13 Nov 2023 12:49:29 +0000 Subject: [PATCH 17/19] jupyter: fix it test --- .../vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts index 224a7b57ee..d03947d303 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts @@ -44,7 +44,7 @@ test.describe('convert job', () => { await page.getByRole('button', { name: 'OK' }).click(); await page.locator('div').filter({ hasText: 'Directory not found' }); - await page.getByRole('button', { name: 'Dismss' }).click(); + await page.getByRole('button', { name: 'Dismiss' }).click(); // get message that the job was converted successfully await page From 8f936cdb2f8987db94a61ab24cc7db9069e44dff Mon Sep 17 00:00:00 2001 From: paulm2 Date: Mon, 13 Nov 2023 13:35:49 +0000 Subject: [PATCH 18/19] jupyter: fix it test --- .../ui-tests/tests/{convert-job.spec.ts => con.spec.ts} | 3 --- 1 file changed, 3 deletions(-) rename projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/{convert-job.spec.ts => con.spec.ts} (98%) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/con.spec.ts similarity index 98% rename from projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts rename to projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/con.spec.ts index d03947d303..922785fb9a 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/con.spec.ts @@ -43,9 +43,6 @@ test.describe('convert job', () => { // Dismiss the dialog that says the operation is running in the background await page.getByRole('button', { name: 'OK' }).click(); - await page.locator('div').filter({ hasText: 'Directory not found' }); - await page.getByRole('button', { name: 'Dismiss' }).click(); - // get message that the job was converted successfully await page .locator('div') From 1e2bca8883a3f0fd05be5e76a2c1d8d1d716c0d2 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Mon, 13 Nov 2023 14:02:24 +0000 Subject: [PATCH 19/19] jupyter: fix it test --- .../ui-tests/tests/{con.spec.ts => convert-job.spec.ts} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/{con.spec.ts => convert-job.spec.ts} (99%) diff --git a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/con.spec.ts b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts similarity index 99% rename from projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/con.spec.ts rename to projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts index 922785fb9a..24b7fe4ba7 100644 --- a/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/con.spec.ts +++ b/projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/ui-tests/tests/convert-job.spec.ts @@ -19,7 +19,7 @@ test.describe('convert job', () => { await page.goto(`tree/${tmpPath}`); }); - + // This Test can fail locally because the paths are too long. test('success', async ({ page }) => { // use VDK menu await page.menu.open('VDK');