fix: isPrerendered now set correctly in static configured redirects. (#13924)

qw-in · ematipico · web-flow · commit 1cd8c3bafca3 · 2025-06-11T05:56:02.000+01:00
* chore: add test for isPrerendered in static redirects

* fix: isPrerendered now set correctly in static configured redirects.

* Update .changeset/sharp-vans-greet.md

---------

Co-authored-by: Emanuele Stoppa &lt;my.burning@gmail.com&gt;
diff --git a/.changeset/sharp-vans-greet.md b/.changeset/sharp-vans-greet.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes an edge case where `isPrerendered` was incorrectly set to `false` for static redirects.
diff --git a/packages/astro/src/core/routing/manifest/create.ts b/packages/astro/src/core/routing/manifest/create.ts
@@ -376,7 +376,7 @@ function createRedirectRoutes(
 			component: from,
 			generate,
 			pathname: pathname || void 0,
-			prerender: false,
+			prerender: getPrerenderDefault(config),
 			redirect: to,
 			redirectRoute: routeMap.get(destination),
 			fallbackRoutes: [],
diff --git a/packages/astro/test/fixtures/static-redirect/astro.config.mjs b/packages/astro/test/fixtures/static-redirect/astro.config.mjs
@@ -0,0 +1,8 @@
+import { defineConfig } from 'astro/config';
+
+// https://astro.build/config
+export default defineConfig({
+  redirects: {
+    '/configured-redirect': '/',
+  },
+});
diff --git a/packages/astro/test/fixtures/static-redirect/package.json b/packages/astro/test/fixtures/static-redirect/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@test/static-redirect",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}
diff --git a/packages/astro/test/fixtures/static-redirect/src/middleware.ts b/packages/astro/test/fixtures/static-redirect/src/middleware.ts
@@ -0,0 +1,8 @@
+import { defineMiddleware } from 'astro:middleware';
+
+export const onRequest = defineMiddleware(({ isPrerendered }, next) => {
+	if (!isPrerendered) {
+		throw new Error('This middleware should only run in prerendered mode.');
+	}
+	return next();
+});
diff --git a/packages/astro/test/fixtures/static-redirect/src/pages/index.astro b/packages/astro/test/fixtures/static-redirect/src/pages/index.astro
@@ -0,0 +1,7 @@
+<html>
+<head>
+</head>
+<body>
+    <p>Hello Astro!</p>
+</body>
+</html>
diff --git a/packages/astro/test/static-build.test.js b/packages/astro/test/static-build.test.js
@@ -205,3 +205,16 @@ describe('Static build SSR', () => {
 		assert.ok(await fixture.readFile('/client/.well-known/apple-app-site-association'));
 	});
 });
+
+describe('Static build with configured redirects', () => {
+	it('Sets isPrerendered true in middleware', async () => {
+		const fixture = await loadFixture({
+			root: './fixtures/static-redirect/',
+		});
+
+		await assert.doesNotReject(
+			fixture.build(),
+			'isPrerendered unexpectedly true during static build',
+		);
+	});
+});
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'astro': patch
 +---
++
 +Fixes an edge case where `isPrerendered` was incorrectly set to `false` for static redirects.