refactor: 오탈자, post 흐름 수정

Author: unluckyjung

app/src/main/java/nextstep/jwp/controller/AbstractController.java

@@ -1,18 +1,17 @@
 package nextstep.jwp.controller;
 
 import java.io.IOException;
-import nextstep.jwp.http.HttpMethod;
 import nextstep.jwp.http.HttpRequest;
 import nextstep.jwp.http.HttpResponse;
 
 public abstract class AbstractController implements Controller {
 
     @Override
     public void service(final HttpRequest httpRequest, final HttpResponse httpResponse) throws IOException {
-        if (httpRequest.getHttpMethod().equals(HttpMethod.GET)) {
-            doGet(httpRequest, httpResponse);
-        } else if (httpRequest.getHttpMethod().equals(HttpMethod.POST)) {
+        if (httpRequest.isPost()) {
             doPost(httpRequest, httpResponse);
+        } else {
+            doGet(httpRequest, httpResponse);
         }
     }
 

app/src/main/java/nextstep/jwp/http/HttpHeaders.java

@@ -50,7 +50,7 @@ public String getAllHeaders() {
         return headerSet.toString();
     }
 
-    public boolean contains(final String key){
+    public boolean contains(final String key) {
         return headers.containsKey(key);
     }
 }

app/src/main/java/nextstep/jwp/http/HttpRequest.java

@@ -68,11 +68,15 @@ public String getBodyDataByKey(final String key) {
         return bodyParams.get(key);
     }
 
-    public boolean contains(final String key){
+    public boolean contains(final String key) {
         return headers.contains(key);
     }
 
     public HttpCookie getCookie() {
         return new HttpCookie(headers.getHeaderDataByKey("Cookie"));
     }
+
+    public boolean isPost() {
+        return requestLine.isPost();
+    }
 }

app/src/main/java/nextstep/jwp/http/RequestLine.java

@@ -69,10 +69,6 @@ public String getHttpVersion() {
         return httpVersion;
     }
 
-    public boolean isQueryParamsEmpty() {
-        return queryParams.isEmpty();
-    }
-
     public boolean isPost() {
         return httpMethod.equals(HttpMethod.POST);
     }

app/src/main/java/nextstep/jwp/service/LoginService.java

@@ -35,7 +35,7 @@ private void userLogin(final HttpRequest httpRequest, final HttpResponse httpRes
         }
     }
 
-    private void sessionCheck(final HttpRequest httpRequest, final HttpResponse httpResponse, final String jsessionId) throws IOException {
+    private void sessionCheck(final HttpRequest httpRequest, final HttpResponse httpResponse, final String jsessionId) {
         if (cookieCheck(httpRequest)) {
             jsessionIdCheck(httpRequest, httpResponse, jsessionId);
             return;
@@ -45,13 +45,13 @@ private void sessionCheck(final HttpRequest httpRequest, final HttpResponse http
 
     private void jsessionIdCheck(final HttpRequest httpRequest, final HttpResponse httpResponse, final String jsessionId) {
         HttpCookie httpCookie = httpRequest.getCookie();
-        if (!httpCookie.containsKey("JSESSIONID")) {
+        if (!httpCookie.containsKey(JSESSIONID)) {
             setJsessionid(httpResponse, jsessionId);
         }
     }
 
     private void setJsessionid(final HttpResponse httpResponse, final String jsessionId) {
-        httpResponse.addHeader("Set-Cookie", String.format("JSESSIONID=%s", jsessionId));
+        httpResponse.addHeader("Set-Cookie", String.format("%s=%s", JSESSIONID, jsessionId));
     }
 
     private void sessionMappingClient(final HttpRequest httpRequest, final String jsessionId) {