XWIKI-23093: Improve deleted documents query

* fix typo
* move the check after the very last modification to the string to validate

(cherry picked from commit dfd0744)

Author: tmortagne

xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/query/hql/internal/DefaultHQLStatementValidator.java

@@ -117,7 +117,7 @@ public void checkOrderBySafe(List<String> allowedPrefixes, String orderByValue)
             }
 
             if (!valid) {
-                throw new QueryException("Usafe ORDER BY value [" + orderByValue + "].", null);
+                throw new QueryException("Unsafe ORDER BY value [" + orderByValue + "].", null);
             }
         }
     }

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/getdeleteddocuments.vm

@@ -49,7 +49,6 @@ $response.setContentType("application/json")
 #set ($order = "$!request.sort")
 #set ($orderQueryPart = '')
 #if ($order != '')
-  #set($discard = $services.query.hql.checkOrderBySafe(['ddoc.'], $order))
   #set ($orderDirection = "$!{request.get('dir').toLowerCase()}")
   #if ("$!orderDirection" != '' && "$!orderDirection" != 'asc')
     #set($orderDirection = 'desc')
@@ -59,6 +58,7 @@ $response.setContentType("application/json")
     ## So we filter on the document full name instead, which is the expected behavior.
     #set ($order = 'ddoc.fullName')
   #end
+  #set($discard = $services.query.hql.checkOrderBySafe(['ddoc.'], $order))
   ## Weird things happen if we use "ORDER BY" (upper case), at least on HSQLDB. Other DBs may behave differently
   #set ($orderQueryPart = "order by ${order} ${orderDirection}")
 #end