Skip to content

react/require-default-props not support type params of React Component #1724

@pmizio

Description

@pmizio
Contributor

When we define Component prop types like this:

type SelectProps = {
  isOpen?: boolean
}
class Select extends PureComponent<SelectProps, SelectState> {
  static defaultProps = {
    // isOpen: false,
  }
  ...
}

We don't get error like this:

17:3 error propType "isOpen" is not required, but has no corresponding defaultProp declaration react/require-default-props

To get this error we need to define component like this:

type SelectProps = {
  isOpen?: boolean
}
class Select extends PureComponent {
  props: SelectProps
  static defaultProps = {
    // isOpen: false,
  }
  ...
}

eslint v: ^4.17.0
eslint-plugin-react v: ^7.6.1

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ljharb@pmizio

        Issue actions

          react/require-default-props not support type params of React Component · Issue #1724 · jsx-eslint/eslint-plugin-react