Update sort-comp for React 16.3+ #1767

Closed

Closed

Update sort-comp for React 16.3+#1767

Labels

help wantedreact 16

opened

on Apr 12, 2018

Contributor

The sort-comp rule will need to be updated to include the new lifecycle methods (while also keeping the older ones, optionally?). These include:

getDerivedStateFromProps
getSnapshotBeforeUpdate
UNSAFE_componentWillMount
UNSAFE_componentWillReceiveProps
UNSAFE_componentWillUpdate

added

on Apr 13, 2018

Also, componentDidCatch is not listed in current sort-comp rule

mentioned this

on Apr 18, 2018

Add support for React 16.3 lifecycle methods in sort-comp #1771

Contributor

I made an attempt to add this feature with #1771

Would love to hear any feedback/suggestions

mentioned this

on Apr 26, 2018

I am confused about the lifecycle sequence in 16.3 airbnb/javascript#1792

Member

Closed in #1771.

closed this as completed

on Apr 26, 2018

mentioned this

Add support for React 16 #1442

mentioned this in 5 pull requests

on May 14, 2018

mentioned this

Update eslint-plugin-react in / from 7.4.0 to 7.8.2 leonardofaria/leozera-ui#197

56 remaining items

mentioned this in 5 pull requests

mentioned this

on May 28, 2019

Add componentDidCatch to lifecycle for react/sort-comp airbnb/javascript#2040

added 8 commits that reference this issue

on Aug 21, 2024

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

fix(deps): update dependency eslint-plugin-react to v7.35.0

added a commit that references this issue

on Dec 24, 2024

fix(deps): update dependency eslint-plugin-react to v7.37.3

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

help wantedreact 16

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Participants