Skip to content

Commit 1031f31

Browse files
authored
Fixes hardcoded Yarn version (#5556)
**What's the problem this PR addresses?** I forgot to remove debug code from the upgrade CTA, causing Yarn to always think it should upgrade to 3.6.0. **How did you fix it?** Removes the hardcoded `3.0.0` version. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
1 parent 360f062 commit 1031f31

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

.yarn/versions/620160d3.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
declined:
2+
- "@yarnpkg/plugin-essentials"

packages/plugin-essentials/sources/commands/install.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import {BaseCommand, WorkspaceRequiredError} from '@yarnpkg/cli';
2-
import {Configuration, Cache, MessageName, Project, ReportError, StreamReport, formatUtils, InstallMode, execUtils, structUtils, LEGACY_PLUGINS, ConfigurationValueMap} from '@yarnpkg/core';
3-
import {xfs, ppath, Filename, PortablePath} from '@yarnpkg/fslib';
4-
import {parseSyml, stringifySyml} from '@yarnpkg/parsers';
5-
import CI from 'ci-info';
6-
import {Command, Option, Usage, UsageError} from 'clipanion';
7-
import semver from 'semver';
8-
import * as t from 'typanion';
1+
import {BaseCommand, WorkspaceRequiredError} from '@yarnpkg/cli';
2+
import {Configuration, Cache, MessageName, Project, ReportError, StreamReport, formatUtils, InstallMode, execUtils, structUtils, LEGACY_PLUGINS, ConfigurationValueMap, YarnVersion} from '@yarnpkg/core';
3+
import {xfs, ppath, Filename, PortablePath} from '@yarnpkg/fslib';
4+
import {parseSyml, stringifySyml} from '@yarnpkg/parsers';
5+
import CI from 'ci-info';
6+
import {Command, Option, Usage, UsageError} from 'clipanion';
7+
import semver from 'semver';
8+
import * as t from 'typanion';
99

1010
const LOCKFILE_MIGRATION_RULES: Array<{
1111
selector: (version: number) => boolean;
@@ -304,7 +304,6 @@ export default class YarnCommand extends BaseCommand {
304304

305305
if (data !== null) {
306306
let newVersion: [string, string] | null = null;
307-
const YarnVersion = `3.0.0`;
308307
if (YarnVersion !== null) {
309308
const isRcBinary = semver.prerelease(YarnVersion);
310309
const releaseType = isRcBinary ? `canary` : `stable`;

0 commit comments

Comments
 (0)