Skip to content

feat: add scaffold script for new pool-level features#1527

Draft
comtalyst wants to merge 1 commit intomainfrom
feat/pool-feature-scaffold-script
Draft

feat: add scaffold script for new pool-level features#1527
comtalyst wants to merge 1 commit intomainfrom
feat/pool-feature-scaffold-script

Conversation

@comtalyst
Copy link
Copy Markdown
Collaborator

@comtalyst comtalyst commented Mar 16, 2026

Description

Adds hack/scaffold-pool-feature.sh — a script that generates boilerplate code stubs for adding a new pool-level feature to Karpenter's AKS Machine API path.

Given a feature name, Go type, and Machine API field location, it outputs:

  • CRD field declaration (for manual insertion into both API versions)
  • configure*() helper function for aksmachineinstancehelpers.go
  • Unit test stubs for suite_aksmachineapi_features_test.go
  • Remaining manual steps checklist

Companion to the developer guide in designs/0009-pool-level-feature-guide.md (PR #1520).

How was this change tested?

Ran the script with multiple feature configurations and verified output matches existing patterns.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened:
  • No

Release Note

NONE

Generates boilerplate code stubs for adding a new pool-level feature
to Karpenter's AKS Machine API path:
- CRD field declaration (for both API versions)
- configure*() helper function
- Unit test stubs
- Remaining manual steps checklist

Usage: ./hack/scaffold-pool-feature.sh <Name> <Type> <Section> <Field> [jsonName]

Companion to the developer guide in designs/0009-pool-level-feature-guide.md.
Addresses the ticket's request for "AI or some scripts" to reduce the
mechanical work of wiring new features.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@comtalyst comtalyst marked this pull request as draft March 17, 2026 00:37
@comtalyst comtalyst marked this pull request as ready for review March 17, 2026 00:59
@comtalyst comtalyst marked this pull request as draft March 17, 2026 01:06
@comtalyst comtalyst added the experimental-please-ignore Issues or PRs that should be ignored unless been told otherwise. label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental-please-ignore Issues or PRs that should be ignored unless been told otherwise.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant