fix: prevent dns_prefix from being set when fqdn_subdomain is used#167
Merged
matt-FFFFFF merged 3 commits intomainfrom Feb 27, 2026
Merged
fix: prevent dns_prefix from being set when fqdn_subdomain is used#167matt-FFFFFF merged 3 commits intomainfrom
matt-FFFFFF merged 3 commits intomainfrom
Conversation
matt-FFFFFF
temporarily deployed
to
empty-no-approval
GitHub Actions
Inactive
matt-FFFFFF
temporarily deployed
to
empty-no-approval
GitHub Actions
Inactive
microsoft-github-policy-service
Bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the Terraform Issue Triage documentation. |
matt-FFFFFF
temporarily deployed
to
empty-no-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnsPrefix, even whenfqdn_subdomainwas set. Azure's API requires these to be mutually exclusive.dnsPrefixproperty is now set tonull(and filtered from the request body) whenfqdn_subdomainis provided.fqdn_subdomain, and explicitdns_prefix.Closes #166