Skip to content

fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled#171

Merged
matt-FFFFFF merged 3 commits intomainfrom
fork-pr-170-fix/20260304-169
Mar 14, 2026
Merged

fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled#171
matt-FFFFFF merged 3 commits intomainfrom
fork-pr-170-fix/20260304-169

Conversation

@matt-FFFFFF
Copy link
Copy Markdown
Member

This PR replaces #170 to enable CI/CD checks with required secrets.

Original PR by @jcmendez-guerrero


Description

This pull request improves the documentation and validation of the name input variable for agent pools, ensuring that naming conventions and constraints are clearly defined and enforced. Additionally, it introduces a configuration file for terraform-docs to standardize documentation generation.

Documentation improvements:

  • Updated the description for the name input variable in README.md, modules/agentpool/README.md, and variables.agent_pool.tf to specify length and character requirements, and to clarify stricter rules when create_before_destroy is enabled. [1] [2] [3]

Validation enhancements:

  • Added a new validation block in modules/agentpool/variables.tf to enforce a maximum length of 8 characters for the name variable when create_before_destroy is enabled.

Documentation tooling:

  • Added .terraform-docs.yml to configure terraform-docs output, enabling consistent and automated documentation generation for the module.

Variable description update:

  • Improved the inline description of the name variable in modules/agentpool/variables.tf to match the updated documentation.

Fixes #169

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@microsoft-github-policy-service
Copy link
Copy Markdown

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the Terraform Issue Triage documentation.

@matt-FFFFFF matt-FFFFFF changed the title fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled [@jcmendez-guerrero] Mar 14, 2026
@matt-FFFFFF matt-FFFFFF changed the title fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled [@jcmendez-guerrero] fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled @jcmendez-guerrero Mar 14, 2026
@matt-FFFFFF matt-FFFFFF changed the title fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled @jcmendez-guerrero fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled Mar 14, 2026
@matt-FFFFFF matt-FFFFFF merged commit 979b519 into main Mar 14, 2026
8 of 16 checks passed
@matt-FFFFFF matt-FFFFFF deleted the fork-pr-170-fix/20260304-169 branch March 14, 2026 08:21
@matt-FFFFFF matt-FFFFFF temporarily deployed to empty-no-approval April 13, 2026 08:11 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Triage 🔍 Maintainers need to triage still

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: App Node Pools Name lenght is not being checked

2 participants