fix(agentpool): [#169] add validation for name length when create_before_destroy is enabled#171
Merged
matt-FFFFFF merged 3 commits intomainfrom Mar 14, 2026
Merged
Conversation
Closed
11 tasks
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the Terraform Issue Triage documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #170 to enable CI/CD checks with required secrets.
Original PR by @jcmendez-guerrero
Description
This pull request improves the documentation and validation of the
nameinput variable for agent pools, ensuring that naming conventions and constraints are clearly defined and enforced. Additionally, it introduces a configuration file forterraform-docsto standardize documentation generation.Documentation improvements:
nameinput variable inREADME.md,modules/agentpool/README.md, andvariables.agent_pool.tfto specify length and character requirements, and to clarify stricter rules whencreate_before_destroyis enabled. [1] [2] [3]Validation enhancements:
modules/agentpool/variables.tfto enforce a maximum length of 8 characters for thenamevariable whencreate_before_destroyis enabled.Documentation tooling:
.terraform-docs.ymlto configureterraform-docsoutput, enabling consistent and automated documentation generation for the module.Variable description update:
namevariable inmodules/agentpool/variables.tfto match the updated documentation.Fixes #169
Type of Change
Checklist