Skip to content

Make benchmark PR comment less verbose#4375

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/refactor-benchmark-comment
Draft

Make benchmark PR comment less verbose#4375
Copilot wants to merge 4 commits intomainfrom
copilot/refactor-benchmark-comment

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026 •
edited
Loading

Benchmark PR comments showed the full metrics table inline, making them noisy on every PR regardless of whether anything changed.

Changes

  • formatPrComment: Restructured comment output:
    • Top-level summary: ✅ "No regressions" when clean, or ⚠️ table of only regressed metrics when slowdowns exceed the threshold
    • Full details table (all metrics, legend, spec info) moved into a collapsed <details> element
  • FormatOptions: Removed changesOnly — superseded by the new structure where full details are always available on demand
  • cli.ts: Removed --changes-only flag and its wiring into formatPrComment

Example output (no regressions):

## ⚡ Benchmark Results

✅ No performance regressions detected.

<details>
<summary>Full details – comparing `abc1234` vs baseline `def5678`</summary>

| Metric | Baseline | Current | Change |
...
</details>

Copilot AI linked an issue May 4, 2026 that may be closed by this pull request
Benchmark comment is a little too verbose. #4374
Open
Copilot AI and others added 2 commits May 4, 2026 21:14
@timotheeguerin
Reduce verbosity of benchmark PR comment: wrap details in <details> e…
c24442e 
…lement, show regression summary

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f466ca11-42d8-472b-9318-2756aad71ca6

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
@timotheeguerin
Fix threshold message and em dash in benchmark PR comment
5bca0f2 
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f466ca11-42d8-472b-9318-2756aad71ca6

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor benchmark comment to reduce verbosity Make benchmark PR comment less verbose May 4, 2026
Copilot AI requested a review from timotheeguerin May 4, 2026 21:16
@timotheeguerin
Copy link
Copy Markdown
Member

timotheeguerin commented May 5, 2026

@copilot run formatter

@timotheeguerin
Run formatter on benchmark source files
a99f13d 
Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/a233d106-06db-4121-be7c-b04165bf5bbd

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 5, 2026

@copilot run formatter

Done in a99f13d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson will be requested when the pull request is marked ready for review bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl will be requested when the pull request is marked ready for review markcowl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@timotheeguerin timotheeguerin

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Benchmark comment is a little too verbose.

2 participants

@timotheeguerin