Skip to content

Updated README.md to include object compare#94

Open
designxtek wants to merge 2 commits intoNagRock:masterfrom
designxtek:designxtek-deepequal-readme
Open

Updated README.md to include object compare#94
designxtek wants to merge 2 commits intoNagRock:masterfrom
designxtek:designxtek-deepequal-readme

Conversation

@designxtek
Copy link
Copy Markdown

In reference to #93 on verifying calls with objects

@NagRock
Copy link
Copy Markdown
Owner

NagRock commented Mar 13, 2018

What do you think about separate section in readme.md about matchers?

@designxtek
Copy link
Copy Markdown
Author

Yeah I could create a separate section. I'm not too familiar with it but I can start something.

@NagRock
Copy link
Copy Markdown
Owner

NagRock commented Mar 13, 2018

Would be great

@designxtek
Copy link
Copy Markdown
Author

Added a new section. Let me know if there is any other changes needed. Thanks

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #94 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   94.58%   94.89%   +0.31%     
==========================================
  Files          35       34       -1     
  Lines         609      607       -2     
  Branches       69       69              
==========================================
  Hits          576      576              
+ Misses         24       22       -2     
  Partials        9        9
Impacted Files Coverage Δ
src/stub/MethodStub.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d6625...996b81f. Read the comment docs.

@yankeeinlondon
Copy link
Copy Markdown

@NagRock I just started using this library yesterday so i'm a newbie but wondering about PR's like this which pass all tests and were introduced over a year ago. Is this library still being supported? Just a bit worried I may have gotten to the party too late 😆

@avneesh91
Copy link
Copy Markdown

@NagRock Can we please merge this, I think a lot of people will go through this issue(and would help to save a lot of time).

Thanks.

@henrikra
Copy link
Copy Markdown

Good to merge!

@alexanderfokau
Copy link
Copy Markdown

Merge when?

@designxtek
Copy link
Copy Markdown
Author

I totally forgot about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants