Skip to content

reduced dimension in hidden & input layer of FCN by 1.#62

Open
tirtho109 wants to merge 2 commits intoalexlenail:masterfrom
tirtho109:master
Open

reduced dimension in hidden & input layer of FCN by 1.#62
tirtho109 wants to merge 2 commits intoalexlenail:masterfrom
tirtho109:master

Conversation

@tirtho109
Copy link
Copy Markdown

Bias shouldn't be counted as layer dimension. So the dimension in the input and hidden layer needs to be reduced by 1 for FCNN.js

@alexlenail
Copy link
Copy Markdown
Owner

Hi @tirtho109
The layer dimension should be dependent on whether the user selects the "show bias units" checkbox. If I'm reading correctly, your PR always decrements the layer width by 1, but we shouldn't assume there's a bias unit unless the user presses the checkbox.

@tirtho109
Copy link
Copy Markdown
Author

Hi @alexlenail, Thanks for the feedback! Can you check one more time?

@alexlenail
Copy link
Copy Markdown
Owner

Why do you need a new state variable wasBiasShown when you already have showBias?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants