Add flags to ignore organisation secrets and to wait for completion#2
Open
michelletaal wants to merge 3 commits intodylan-smith:mainfrom
Open
Add flags to ignore organisation secrets and to wait for completion#2michelletaal wants to merge 3 commits intodylan-smith:mainfrom
michelletaal wants to merge 3 commits intodylan-smith:mainfrom
Conversation
Owner
|
This looks like a good improvement, I reviewed the code and it looks good, I want to run a couple manual tests on it before I merge it. Will try to find some time in the next few days. Thanks for the contribution! |
|
Hi @dylan-smith, did you finish the tests? Do you intend to merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given this POC repository is currently GH's recommended best existing solution for migrating secrets, I'm hoping to extend the current functionality to serve our use case better.
Added two flags:
I also added a slug to the branch names to reduce branch naming conflict.