Draft
Conversation
Member
If you feel that is the right approach, I really do not mind. These type of configuration are barely the "every day" situation. So, feel free to create a Try to keep safety checks at compile-time as much as we can. Make it work, then make it beautiful. |
tomekowal
force-pushed
the
support-hackney-2.x
branch
from
fe6f5f9 to
d97f067
Compare
tomekowal
force-pushed
the
support-hackney-2.x
branch
from
d97f067 to
5c37538
Compare
- Handle PID connection handles (hackney 2.x+ uses PIDs instead of refs) - Add finish_send_body call for streaming requests - Convert cacertfile to cacerts for hackney 3.x SSL compatibility - Use hackney_conn.body/2 for reading response body in hackney 3.x - Remove deprecated max_body test (hackney 3.x changed body reading API) - Require hackney >= 3.2.1 (fixes recv_timeout with connection pooling) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tomekowal
force-pushed
the
support-hackney-2.x
branch
from
5c37538 to
b4e3ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a starting point on supporting hackney 2.x by tesla.
So far:
TBD:
TODO:
Note: the tests here are green because they still use old hackney. On new version