Draft
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
NullVoxPopuli
approved these changes
Jun 23, 2025
Contributor
|
Similar to what I said about the ArrayProxy deprecation: the hard part here is the interop with computeds. |
Contributor
Author
|
I've added a note about Computed Properties. |
ef4
reviewed
Aug 15, 2025
|
|
||
| ### `A()` Function and Core Mixins | ||
|
|
||
| The `A()` function would wrap a native array, making it an `EmberArray`. The `EmberArray` and `MutableArray` mixins could be used to build custom array-like classes. |
Contributor
There was a problem hiding this comment.
If I remember correctly, the A() function actually mutates its argument by enhancing its prototype. This description of A() should probably say that. The failure mode is that someone removes an A() in one part of their app and a far-away part breaks because that part was subtly relying on the prototype extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: emberjs/rfcs#1114
Note that Ember.ArrayProxy deprecation guides are in #1405.