Write new files only if file size is reduced#400
Open
mattyrob wants to merge 2 commits intogruntjs:mainfrom
Open
Write new files only if file size is reduced#400mattyrob wants to merge 2 commits intogruntjs:mainfrom
mattyrob wants to merge 2 commits intogruntjs:mainfrom
Conversation
Author
|
The Dependency upgrade address (all) 6 Critical, 12 High and 7 Moderate rated vulnerabilities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly updated the logic when processing files through the minification process.
Currently a conditional statement tracks if the file size has been reduced but all of the files a re-written, this means that files of the same size, or even larger files could be produced.
Moving the file write commands within the conditional statement will ensure files are only written when the file size has been reduced.
Also, I have included updated
package-lock.jsonthat includes some minor dependency updates that should be no-breaking without further manual testing required.