Fix concurrent access to result map when merging coverage#1425
Open
ssams wants to merge 1 commit intoistanbuljs:mainfrom
Open
Fix concurrent access to result map when merging coverage#1425ssams wants to merge 1 commit intoistanbuljs:mainfrom
ssams wants to merge 1 commit intoistanbuljs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1424
Note that an alternative implementation could be made using p-reduce which might be slightly more efficient as it could start processing whilst files are still in the process of being loaded. However, this would require switching to ESM ... hence I decided on a simpler approach without introducing a new dependency for now (it also would not support limit concurrency at the moment, sindresorhus/p-reduce#4, thus requiring another dependency to p-limit).