Depend on slop 3.0 or above#135
Merged
jugyo merged 1 commit intojugyo:masterfrom Aug 7, 2012
eitoball:slop_3
Merged
Conversation
Owner
|
Cool!! |
|
This should be fixed in leejarvis/slop#86 you should be able to remove any hacks now once I've released a new bugfix version. Sorry for the issue, please let me know in the Slop tracker if you find anything weird happening, or of course if there's anything you'd like integrated to help earthquake. |
|
I've also noticed that you've bumped to Slop 3.0 without fixing any of the incompatibilities with 2.0. Mostly here from what I can see. Slop 3 doesn't support the |
Contributor
Author
|
@injekt thanks for fix and suggestion. I will try to write and submit a patch based on your suggestion this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #134, but it is really ugly. The ugly part is to work around a bug in slop. For example,
I think that this should be true. Maybe, slot 2.x returns true?
Anyway, this command parsing logic should be refactored like discussed in #121.