Conversation
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
…hould never ever work as uint64, unary minus would have always typecasted this implicitly to signed anyway
…h a lot of comments from Petr
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
Co-authored-by: Petr Pučil <petr.pucil@seznam.cz>
…cpkg instructions to build Mingw-specific build
…tr() being unused if KS_STR_ENCODING_NONE
…files mingw make generates
…ent places in run-unittest.ps1
…manual validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds compilation and test running validation for Mingw on Windows using GitHub Actions CI. The implementation itself is pretty straightforward, as default GH Actions Windows image has Mingw 11.0 preinstalled.
Compilation issues
src_encparameter inkaitai::kstream::bytes_to_stris unused and compiler complains about that. Silenced it using https://stackoverflow.com/a/1486931 (which is ancient, but works).