Conversation
…8.1 + C++98 build on macos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relatively recently, GitHub Actions upgraded their macos images, bringing in macos 15, XCode 16.4.0.0.1.1747106510, Clang/LLVM 17.0.0, Cmake 4.2.3.
Stricter checks introduced all around the tooling broke a few that previously considered warnings in our codebase + old Google Test we used for C++98.
This works around such errors with C++11 extensions in Google Test 1.8.1 + C++98 build on macos.