Alpine image: Install NodeJS for Matter binding#454
Merged
wborn merged 2 commits intoopenhab:mainfrom Jun 2, 2025
Merged
Conversation
wborn
requested changes
Jan 7, 2025
florian-h05
force-pushed
the
alpine-nodejs
branch
from
e79d4d8 to
61b961d
Compare
6 tasks
Contributor
Author
|
The Matter PR has just been merged 🥳 |
|
Thanks @florian-h05 , i wondering since we will need to support 5.0 and beyond, if we should check if its at least v5 or greater then install. I guess eventually we will want to remove once we stop supporting 4.x. Maybe something like if [ "$(echo "$version" | sed -E 's/^([0-9]+).*/\1/')" -ge 5 ]; then apk add --no-cache nodejs; fi && \ |
Contributor
Author
|
@digitaldan I just updated the code to check for openHAB >= 5 👍 |
|
LGTM, not sure what github is complaining about? |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
force-pushed
the
alpine-nodejs
branch
from
d67c896 to
d0fdd9d
Compare
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
force-pushed
the
alpine-nodejs
branch
from
b0e88ea to
7cc19c5
Compare
Contributor
Author
|
Looks good now, I have fixed ShellCheck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See openhab/openhab-distro#1693 (comment).