Open
Conversation
Signed-off-by: DigiH <17110652+DigiH@users.noreply.github.com>
…r user opt-in Adds alwaysSendSameAuthenticationToWebView to HomePreferences so users can opt in to sending server credentials to all web view authentication challenges. Without the flag, credentials are still forwarded automatically when the challenge host matches a configured server URL or is home.myopenhab.org. Also adds a custom Codable decoder to HomePreferences using decodeIfPresent for all fields to ensure backward compatibility when new keys are introduced. Fixes #1034 Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
5 tasks
Move the always-send-credentials toggle inside the Group so it renders within the connection settings section. Remove erroneous await from a synchronous property access and use existential any Decoder syntax. Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on DigiH:settings.
Summary
alwaysSendSameAuthenticationToWebViewtoHomePreferences— when enabled, server credentials are forwarded to all web view authentication challenges regardless of hosthome.myopenhab.org, with no setting change requiredCodabledecoder toHomePreferencesusingdecodeIfPresentfor all fields, ensuring existing users don't lose their preferences when new keys are introducedFixes #1034
Test plan
home.myopenhab.orgauthenticates web views correctly without enabling the toggle