De-duplicate boardinglocations on areas#7508
Open
MaxGosau wants to merge 3 commits intoopentripplanner:dev-2.xfrom
Open
De-duplicate boardinglocations on areas#7508MaxGosau wants to merge 3 commits intoopentripplanner:dev-2.xfrom
MaxGosau wants to merge 3 commits intoopentripplanner:dev-2.xfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7508 +/- ##
=============================================
+ Coverage 71.02% 71.32% +0.29%
- Complexity 21002 21146 +144
=============================================
Files 2352 2357 +5
Lines 87266 87552 +286
Branches 8635 8660 +25
=============================================
+ Hits 61983 62446 +463
+ Misses 22293 22101 -192
- Partials 2990 3005 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Maybe it would be better to use the |
3457c6e to
514f5f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
when two stops reference the same OSM platform area (via ref:IFOPT), only one OsmBoardingLocationVertex centroid is created for that area and both stops are linked to it. This ensures that transfers on the same platform can always be reached (0-min transfers).
Issue
the issue was previously discussed here: #7240
this PR implements the "Quick fix" outlined by Jessica
The Sollution uses a simple HashMap to ensure that only one OsmBoardingLocationVertex gets created for each stop connected to an area.
This will have an impact on all transfers using the same OSM Area


Before:
After:
The main difference being, that there is no longer a footpath in the resulting itinerary (instantaneous transfer).
Some minor refactorings to OsmBoardingLocationsModule were also added in a seperate commit: (Refactor OsmBoardingLocationsModule for simplicity)
Unit tests
One of the existing unit test cases uses an example in Herrenberg, which already included an OSM area with 2 stoppoints, so only a new testcase was added, to verify the de-duplication
Documentation