Open
Conversation
Deploying infrahub-ansible with
|
| Latest commit: |
201f655
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9a4bcc0a.infrahub-ansible.pages.dev |
| Branch Preview URL: | https://pog-consolidate-has-infrahub.infrahub-ansible.pages.dev |
ogenstad
force-pushed
the
pog-consolidate-HAS_INFRAHUBCLIENT
branch
from
ba1334d to
848657c
Compare
ogenstad
force-pushed
the
pog-consolidate-HAS_INFRAHUBCLIENT
branch
from
848657c to
201f655
Compare
BeArchiTek
approved these changes
Jun 23, 2025
Contributor
Author
|
@BeArchiTek, this was just something that I considered while looking at this repo. I'm not sure it turned out that great as Ansible had some restrictions with regards to the imports in place. My goal was just to familiarize myself with the code and noticed something that could later improve code coverage to avoid having to test for issues if the SDK was installed in multiple places. It still might be a bit cleaner than what we had but I'm not completely sure, what do you think? |
Contributor
|
Let's say those checks grow organically to please ansible-lint... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrast to Current Behavior
This PR consolidates some of the code and behaviour around HAS_INFRAHUBCLIENT