Skip to content

Optimize class matching in Floki.Selector #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philss merged 1 commit into from
Mar 17, 2026
+7 −3
Merged

Optimize class matching in Floki.Selector #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/floki/selector.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,13 @@ defmodule Floki.Selector do
end

defp do_classes_matches?(class_attr_value, classes) do
min_size = Enum.reduce(classes, -1, fn item, acc -> acc + 1 + bit_size(item) end)
can_match? = bit_size(class_attr_value) >= min_size
can_match? && classes -- String.split(class_attr_value, [" ", "\t", "\n"], trim: true) == []
if Enum.all?(classes, &String.contains?(class_attr_value, &1)) do
min_size = Enum.reduce(classes, -1, fn item, acc -> acc + 1 + bit_size(item) end)
can_match? = bit_size(class_attr_value) >= min_size
can_match? && classes -- String.split(class_attr_value, [" ", "\t", "\n"], trim: true) == []
else
false
end
end

defp attributes_matches?(_node, []), do: true
Expand Down
Loading