Conversation
|
Please check out the new API at 1d03b05 |
|
Also, if this is done, I think it would make more sense for consistency with current behavior to be disabled by default. Just a suggestion though but not to adamant about it. |
|
Auto Skip Disabled by Default |
fire-light42
left a comment
There was a problem hiding this comment.
While I have no doubt this works fine, the logic is hard to follow given the indirect recursion and global variables. I think it would be much cleaner if this was a simple for loop inside a suspended context. Then you only need a single "Job" variable that can be canceled.
fire-light42
left a comment
There was a problem hiding this comment.
Good changes, but I think you can simplify this even more! ❤️
|
Done |
fire-light42
left a comment
There was a problem hiding this comment.
Good improvements, however while testing it I found that it is impossible to cancel it manually. Normally you either have a 5s countdown with a cancel button, or auto skip instantly. TV devices often cancel it immediately on any key-press.
So my question is: Is this the intended experience?
Yes I guess do we need that ? |
Trying to implement auto-skip; used AI for guidance.
Added a setting to disable it as well.