Conversation
som-sm
force-pushed
the
chore/migrate-to-xo-2
branch
2 times, most recently
from
c680bb4 to
1f34c53
Compare
| '@stylistic/function-paren-newline': 'off', | ||
| '@stylistic/object-curly-newline': 'off', | ||
| '@stylistic/curly-newline': 'off', | ||
| '@stylistic/operator-linebreak': ['error', 'before', {overrides: {'=': 'after'}}], |
There was a problem hiding this comment.
'@stylistic/operator-linebreak' is a useful rule, so instead of turning it off, fixed all the errors reported by this, like:
{overrides: {'=': 'after'}} is because I feel like it's better to have the line break after = rather than before it.
| '@typescript-eslint/consistent-indexed-object-style': 'off', | ||
| '@typescript-eslint/unified-signatures': 'off', // Temp | ||
| '@typescript-eslint/no-unnecessary-type-arguments': 'off', | ||
| '@typescript-eslint/no-unsafe-type-assertion': 'off', |
There was a problem hiding this comment.
Can't have this because we have assertions like {} as ... everywhere in tests. And in source files, there's no scope for assertions.
| '@stylistic/quote-props': 'off', | ||
| '@stylistic/function-paren-newline': 'off', | ||
| '@stylistic/object-curly-newline': 'off', | ||
| '@stylistic/curly-newline': 'off', |
There was a problem hiding this comment.
Turned this off because it seems to have conflicts with other rules. And also there's no good default for this rule for our codebase.
xo.config.js
Outdated
| '@stylistic/curly-newline': 'off', | ||
| '@stylistic/operator-linebreak': ['error', 'before', {overrides: {'=': 'after'}}], | ||
| 'n/file-extension-in-import': 'off', | ||
| 'unicorn/require-module-specifiers': 'off', |
There was a problem hiding this comment.
Turned this off because source files have export {}.
som-sm
force-pushed
the
chore/migrate-to-xo-2
branch
from
1f34c53 to
a30b733
Compare
som-sm
force-pushed
the
chore/migrate-to-xo-2
branch
from
a30b733 to
8da93e0
Compare
| paths: ['tsd', 'expect-type'], | ||
| }, | ||
| ], | ||
| 'unicorn/require-module-specifiers': 'off', |
There was a problem hiding this comment.
Can't have this in .d.ts files because there we have export {}.
| @@ -110,6 +121,7 @@ const xoConfig = [ | |||
| '@stylistic/eol-last': 'off', | |||
| 'capitalized-comments': 'off', | |||
| 'unicorn/prefer-structured-clone': 'off', | |||
| 'unicorn/no-immediate-mutation': 'off', | |||
| }, | |||
There was a problem hiding this comment.
Can't have unicorn/no-immediate-mutation enabled in tests and JSDoc codeblocks because we need this at times.
2 participants
Update to XO v2 & ESLint v10.
Majority of the changes in this PR are styling-related. The ones which are not are also pretty simple, like:
.sortwith.toSorted.BigIntconstructor calls to bigint literals.vflag to regular expression.