perf(deps): externalize lodash-es via shared to reduce install size#3292
Merged
perf(deps): externalize lodash-es via shared to reduce install size#3292
lodash-es via shared to reduce install size#3292Conversation
Deploying rspress-v2 with
|
| Latest commit: |
c0de952
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://205318a1.rspress-v2.pages.dev |
| Branch Preview URL: | https://vk-a775-lodash-es-depend.rspress-v2.pages.dev |
SoonIter
changed the title
lodash-es via shared
Co-Authored-By: Aiden
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR routes all lodash-es usage through a new @rspress/shared/lodash-es entrypoint and removes lodash-es as a runtime dependency from @rspress/core.
Changes:
- Added
@rspress/shared/lodash-esentrypoint and updated@rspress/coreimports to consume it. - Adjusted
@rspress/sharedbuild/export config to publish the new subpath. - Updated dependencies/changeset to reflect moving
lodash-esout of@rspress/core.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/node-utils/merge.ts | Switches from dynamic lodash-es import to shared entrypoint import. |
| packages/shared/src/lodash-es.ts | Introduces the new re-exporting shared lodash-es facade. |
| packages/shared/rslib.config.ts | Adds a build entry for the new lodash-es subpath. |
| packages/shared/package.json | Exposes ./lodash-es subpath and changes how lodash-es is declared. |
| packages/core/src/theme/components/Search/SearchPanel.tsx | Updates debounce import to shared lodash-es entry. |
| packages/core/src/node/ssg/renderPages.ts | Updates chunk import to shared lodash-es entry. |
| packages/core/src/node/runtimeModule/pageData/createPageData.ts | Updates groupBy import to shared lodash-es entry and adds callback typing. |
| packages/core/package.json | Removes lodash-es (and its types) from core dependencies. |
| .changeset/tall-walls-matter.md | Adds a changeset documenting the dependency move. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SoonIter
force-pushed
the
vk/a775-lodash-es-depend
branch
from
01f3676 to
c0de952
Compare
SoonIter
changed the title
lodash-es via sharedlodash-es via shared to reduce install size
Contributor
Rsdoctor Bundle Diff AnalysisFound 3 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Timeless0911
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lodash-esout of@rspress/coreruntime dependencies@rspress/shared/lodash-esand route existing lodash imports through the shared entryTesting