Make Connect Service k8s resource type configurable #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leftover from helm starter template?
|
I'd like to see ClusterIP be the default value. Users should explicitly opt in if they want to expose this outside of their cluster. |
florisvdg
reviewed
Sep 13, 2021
florisvdg
approved these changes
Nov 17, 2021
Merged
jeroenvermeulen
added a commit
to jeroenvermeulen/connect-helm-charts
that referenced
this pull request
Oct 25, 2023
I have tested `connect.serviceType=ClusterIP` and it works and does indeed not expose a port. On our cluster all internal services were using ClusterIPs except for 1Password Connect. We prefer not to open any unnecessary ports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the connect chart had default values for
service.typeandservice.portthat went unused. Having the ability to create aClusterIPservice for use inside our cluster only rather thanNodePortexposed on the node IPs better fits our use case.This PR cleans up the unused
service.*default values and addsconnect.serviceType, defaulted toNodePortto match the hardcoded value, for this purpose.