Skip to content

Bump tungstenite version to v0.20.1 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

george-keyrock
Copy link
Contributor

This PR bumps the tungstenite (and tokio-tungstenite ) version to 0.20.1 to resolve a vulnerability.

Copy link
Owner

@1c3t3a 1c3t3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! That's great :) I just had one comment!

Copy link
Owner

@1c3t3a 1c3t3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #368 (a2f0212) into main (5f86ee0) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head a2f0212 differs from pull request most recent head 9a71704. Consider uploading reports for the commit 9a71704 to get more accurate results

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   90.88%   90.96%   +0.08%     
==========================================
  Files          37       37              
  Lines        4727     4727              
==========================================
+ Hits         4296     4300       +4     
+ Misses        431      427       -4     
Files Coverage Δ
.../asynchronous/async_transports/websocket_secure.rs 98.18% <100.00%> (ø)

... and 3 files with indirect coverage changes

@1c3t3a
Copy link
Owner

1c3t3a commented Oct 23, 2023

Argh, can you please reformat? Last request, sorry😉

@george-keyrock
Copy link
Contributor Author

That should be it now - thanks @1c3t3a !

@1c3t3a 1c3t3a merged commit 335a4d8 into 1c3t3a:main Oct 23, 2023
@george-keyrock
Copy link
Contributor Author

Hey @1c3t3a thanks for the review/merge - any idea when this change would make it into a release?

@1c3t3a
Copy link
Owner

1c3t3a commented Oct 25, 2023

I can release a new version on the weekend :)

@1c3t3a
Copy link
Owner

1c3t3a commented Nov 18, 2023

Sorry for the delay, just published 0.4.4 with your changes just now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants