-
Notifications
You must be signed in to change notification settings - Fork 373
Enable SFT for multimodal llama4 #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7846a54
to
62d1e5a
Compare
62d1e5a
to
253903d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the quick implementation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One question, have a you checked the ckpt from SFT (i.e. 50-100 steps), and do some decoding and see if it makes sense in the output?
253903d
to
2d67f70
Compare
We haven't checked yet, after the functionality added with this PR. We plan to run more SFT tests, ideally with a bigger dataset since llama4 models are quite big. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. The decoding test will be verified as follow up.
5408ce0
to
4296375
Compare
4296375
to
3b471d5
Compare
Description
Vanilla SFT support for multimodal llama4
Tests
TODOs for future PRs:
Checklist
Before submitting this PR, please make sure (put X in square brackets):