Skip to content

Client Setting request counter doesn't work when using CIDR for the IP #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bruvv opened this issue Apr 12, 2021 · 17 comments
Closed

Client Setting request counter doesn't work when using CIDR for the IP #2945

bruvv opened this issue Apr 12, 2021 · 17 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.107.62

Comments

@bruvv
Copy link
Contributor

bruvv commented Apr 12, 2021 •
edited
Loading

Issue Details

Expected Behavior

When filling in the identifier field the IP
89.205.224.0/24
I assume that it does: 89.205.224.*
and therefor count all the requests that matches the above wildcard IP. But that doesn't work and the counter becomes 0.

I tried:
89.205.224.1/24
But that doesn't work either.

Actual Behavior

It doesn't count any requests in the client settings page. Only when filling in the complete IP it does count as can be seen in the screenshots below:

Screenshots

afbeelding
afbeelding
@ainar-g
Copy link
Contributor

ainar-g commented Apr 12, 2021

Hi, thank you for your report. What exactly do you mean by “doesn't work”? Do you only mean the request count and statistics or something else?

@ainar-g ainar-g added the waiting for data Waiting for users to provide more data. label Apr 12, 2021
@bruvv
Copy link
Contributor Author

bruvv commented Apr 12, 2021

Sorry I should clarify. As can bee seen in the screenshots, the request counter doesn't count in the Client settings page.

@bruvv bruvv changed the title Client Setting CIDR /24 does not work Client Setting requst counter doesn't work when using CIDR /24 Apr 12, 2021
@bruvv bruvv changed the title Client Setting requst counter doesn't work when using CIDR /24 Client Setting requst counter doesn't work when using CIDR for the IP Apr 12, 2021
@bruvv bruvv changed the title Client Setting requst counter doesn't work when using CIDR for the IP Client Setting request counter doesn't work when using CIDR for the IP Apr 12, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Apr 12, 2021

It's clearer now, thanks. We cannot reproduce the issue on our machines. Could you please add the following information:

  1. Did you reset statistics between removing the IP and adding the CIDR? If so, are you sure there were actually requests from that IP address?
  2. Is IP anonymisation enabled?
  3. Which browser are you using? Are there any errors in your browser's console?
  4. Can you configure AdGuard Home to collect verbose logs and see if there are any statistics-related errors? Perhaps attach a log here?

Thanks!

@bruvv
Copy link
Contributor Author

bruvv commented Apr 12, 2021 •
edited
Loading

  1. I did not reset the statistics. I am also not removing the ip, just editting it, in the "edit client" window.
  2. No
  3. I have used Edge, chrome and firefox
  4. Here you go: https://pastebin.com/Vpqn2pW4 booted, changed the ip to a CIDR ip and then exited the docker again.

I am running this all on a oracle cloud server btw. If that is of any use.

@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Apr 14, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Apr 14, 2021

Thanks for the data! We'll look into it further.

@bruvv
Copy link
Contributor Author

bruvv commented Apr 15, 2021 •
edited
Loading

Maybe another way to investigate:
When I go to the query log and fill in:
"89.205.224.0/24"
It also doesn't show anything

@ainar-g ainar-g removed the waiting for data Waiting for users to provide more data. label Nov 1, 2021
@ainar-g ainar-g added this to the v0.107.1 milestone Nov 1, 2021
@ainar-g ainar-g added bug P3: Medium and removed needs investigation Needs to be reproduced reliably. labels Dec 27, 2021
@EugeneOne1
Copy link
Member

@bruvv, hello again and apologies for a continuous idle on the issue. Could you please help us a bit more? We've made lots of changes during v0.107.0 cycle, including clients handling and enhanced logging. Could you please try one of the latest builds, either the release one, or the ones from edge/beta channels? If the issue reproduces there, could you please collect the verbose log once again?

@bruvv
Copy link
Contributor Author

bruvv commented Dec 28, 2021 •
edited
Loading

Still not working on v0.107.0 When searching for a client using CIDR:
afbeelding

afbeelding

@EugeneOne1
Copy link
Member

@bruvv, I see. And what about the requests counter on the Clients page? Does it sums all the requests of users contained by the subnet?

@bruvv
Copy link
Contributor Author

bruvv commented Dec 28, 2021 •
edited
Loading

Hi @EugeneOne1 that is a negative:
afbeelding
afbeelding
afbeelding

@EugeneOne1
Copy link
Member

@bruvv, well, we're already working on it. Would you mind collecting verbose log once again? I'd be really helpful. Thanks.

@ainar-g
Copy link
Contributor

ainar-g commented Dec 28, 2021

I should add that the query log search one will probably not work until we revamp the search engine there. But the client counter on the “Clients” definitely needs a fix.

@bruvv
Copy link
Contributor Author

bruvv commented Dec 29, 2021

and here is the verbose @EugeneOne1:
https://pastebin.com/nH0f36tw

@ainar-g ainar-g modified the milestones: v0.107.1, v0.107.2, v0.107.3 Dec 29, 2021
@EugeneOne1
Copy link
Member

@bruvv, unforunately, we still can't reproduce the behavior. However, we're planning a massive refactoring around v0.108.0 including the rework on statistics module that should improve it's stability. Perhaps that will help.

@EugeneOne1 EugeneOne1 removed this from the v0.107.3 milestone Jan 21, 2022
@EugeneOne1 EugeneOne1 added this to the v0.107.62 milestone May 21, 2025
adguard pushed a commit that referenced this issue May 21, 2025
@ainar-g
Pull request 2413: 2945-fix-stats-in-client-table
cb854d2 
Updates #2945.

Squashed commit of the following:

commit 305026d
Author: Ainar Garipov <[email protected]>
Date:   Wed May 21 14:37:58 2025 +0300

    all: upd chlog

commit bb8288c
Author: Ainar Garipov <[email protected]>
Date:   Wed May 21 14:31:04 2025 +0300

    client: fix types in helper
adguard pushed a commit that referenced this issue May 21, 2025
@ainar-g @EugeneOne1
Pull request 2413: 2945-fix-stats-in-client-table
de5649e 
Updates #2945.

Squashed commit of the following:

commit 305026d
Author: Ainar Garipov <[email protected]>
Date:   Wed May 21 14:37:58 2025 +0300

    all: upd chlog

commit bb8288c
Author: Ainar Garipov <[email protected]>
Date:   Wed May 21 14:31:04 2025 +0300

    client: fix types in helper
@EugeneOne1
Copy link
Member

@bruvv, hello again. We've finally reproduced the bug and have already pushed a new edge build that should resolve the issue. Could you please check, if the issue has been fixed there?

@bruvv
Copy link
Contributor Author

bruvv commented May 21, 2025

Nice of you to come back to this issue! I’m not using adguard anymore. Would you like me to close this issue ?

@EugeneOne1
Copy link
Member

@bruvv, well, we'll close it ourselves then. Thank you again for reporting it.

@sourcery-ai sourcery-ai bot mentioned this issue May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.62
Development

No branches or pull requests
3 participants
@bruvv @ainar-g @EugeneOne1