Repository navigation
test(sdk/python): drop the stale enable_mcp kwarg from Agent fixtures - #1120
Merged
Merged
Conversation
FastAPI 0.148.0 (released 2026-10-19) no longer accepts unknown keyword arguments in FastAPI.__init__. Agent forwards its extra kwargs to FastAPI, and six tests still passed enable_mcp=False, an Agent parameter that no longer exists, so they now fail with a TypeError and break the sdk-python coverage job on every PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Performance
✓ No regressions detected |
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FastAPI 0.148.0, released today, no longer accepts unknown keyword arguments in
FastAPI.__init__.Agentforwards its extra kwargs to FastAPI, and six tests still passedenable_mcp=False, anAgentparameter that no longer exists. They now fail withTypeError: FastAPI.__init__() got an unexpected keyword argument 'enable_mcp', which failscoverage (sdk-python)and therefore the requiredcoverage-summarycheck on every open PR.This removes the stale kwarg from those six fixtures. No SDK code changes.
Testing
ruff check .(ruff 0.15.22): clean./scripts/run_pytest.shwith FastAPI 0.148.0 on Python 3.12: 2558 passed, 4 skipped, 0 failed🤖 Generated with Claude Code