Variation of ses-ava test with deep stacks

[erights]

Modeled on https://github.com/endojs/endo/blob/master/packages/ses-ava/test/test-ses-ava-reject.js but with E.when rather than .then in order to show deep stacks.

Until endojs/endo#579 is fixed, both comment out the code being tested because when it is not commented out it causes the ava failure that is the point of the test, but this means that yarn test fails and therefore that CI fails.

[erights]

This is now ready for review.

[dckc]

Commented out tests seem really awkward.

Perhaps use t.skip?

Or perhaps the pattern from test-deep-stacks.js?

agoric-sdk/packages/eventual-send/test/test-deep-stacks.js

Lines 15 to 18 in bae5b0d

	return q.catch(reason => {
	t.assert(reason instanceof Error);
	console.log('expected failure', reason);
	});

I played around with it and came up with...

Suggested change

	// Uncomment this to see something like the text in the extended comment below
	/*
	return E.when(Promise.resolve(null), v1 =>
	E.when(v1, v2 =>
	E.when(v2, _ => {
	assert.typeof(88, 'string', assert.details`msg ${'NOTICE ME'}`);
	}),
	),
	);
	*/
	const q = E.when(Promise.resolve(null), v1 =>
	E.when(v1, v2 =>
	E.when(v2, _ => {
	assert.typeof(88, 'string', assert.details`msg ${'NOTICE ME'}`);
	}),
	),
	);
	return q.catch(reason => {
	t.assert(reason instanceof Error);
	t.notRegex(reason.message, /NOTICE ME/, 'message detail hidden');
	console.log('expected failure', reason);
	});

[dckc]

meanwhile our tests aren't supposed to console.log. t.log would be silent unless ava -v were used...

    t.log('expected failure', reason);

but it's not integrated with the SES console, so we get the boring...

  ✔ ses-ava-reject-deep-stacks › ses-ava reject console output
    ℹ expected failure TypeError {
        message: 'msg (a string)',
      }

I'm raising an issue on ses-ava about t.log support.

[erights]

I do not understand this. Let's discuss soon.

[kriskowal]

ses-ava is coming from npm, which does not carry our dev versions.

Suggested change

	"@agoric/ses-ava": "^0.1.0+1-dev",
	"@agoric/ses-ava": "^0.1.0",

[erights]

Closing in favor of endojs/endo#1591

[erights]

Closed the wrong PR. Reopening

[erights]

Closing in favor of endojs/endo#1592